Feature - Refactoring @Field decorator #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipesabino
force-pushed
the
feature/refactor-field
branch
from
d49d5b5
to
25b3235
Compare
felipesabino
changed the title
felipesabino
changed the title
tibawatanabe
approved these changes
Nov 5, 2017
src/pagination.middleware.ts
Outdated
| @@ -0,0 +1,27 @@ | |||
| import 'reflect-metadata'; | |||
There was a problem hiding this comment.
Do we need this here? I'm not finding a need...
There was a problem hiding this comment.
I think there are some unneeded imports of reflect-metadata
I was getting a lot of error like
Uncaught TypeError: Reflect.getMetadata is not a function
So this helped me suppress it... found this solution here but do not know a better alternative.
Do you know the root cause for it? Any idea if something at tsconfig might fix this issue without these imports?
ArgumentArg... a little bit strange but I have no better suggestion
Same here 😞
There was a problem hiding this comment.
I think there are some unneeded imports of reflect-metadata
Ok, I did some reading and I need it just in my app/lib entry point, so I added it to both index.ts and *.spec.ts
thiago-soliveira
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry but this will be a big PR with a lot of breaking changes
@Fielddecorator and nested dependencies (@Arg,@OrderBy,@Root,@Beforeand@Ctx) - Refactor decorators class structure #22DefaultOption,DefaultMetadataandDefaultArginterfaces to justOption,MetadataandArgumentinstead as in Feature - Refactoring more decorators #32 (comment)MetadataBuilderinstead ofReflect)field_type_factoryto handle metadata properly and to be less verbose/confusingTODOs for possible missing tests@Pagination@Description@List@NonNull