.github/workflows/workspace.yml #1162
Annotations
10 warnings
Run actions-rs/clippy@master:
python-packed-resources/src/parser.rs#L65
warning: variable does not need to be mutable
--> python-packed-resources/src/parser.rs:65:13
|
65 | let mut state = self.blob_sections[resource_field as usize]
| ----^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
Run actions-rs/clippy@master:
python-packed-resources/src/parser.rs#L516
warning: the following explicit lifetimes could be elided: 'a
--> python-packed-resources/src/parser.rs:516:23
|
516 | pub fn load_resources<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
516 - pub fn load_resources<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
516 + pub fn load_resources(data: &[u8]) -> Result<ResourceParserIterator<'_>, &'static str> {
|
|
Run actions-rs/clippy@master:
python-packed-resources/src/parser.rs#L530
warning: the following explicit lifetimes could be elided: 'a
--> python-packed-resources/src/parser.rs:530:22
|
530 | fn load_resources_v3<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
530 - fn load_resources_v3<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
530 + fn load_resources_v3(data: &[u8]) -> Result<ResourceParserIterator<'_>, &'static str> {
|
|
Run actions-rs/clippy@master:
python-packed-resources/src/resource.rs#L120
warning: the following explicit lifetimes could be elided: 'a
--> python-packed-resources/src/resource.rs:120:6
|
120 | impl<'a, X> Default for Resource<'a, X>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
120 - impl<'a, X> Default for Resource<'a, X>
120 + impl<X> Default for Resource<'_, X>
|
|
Run actions-rs/clippy@master:
python-packaging/src/interpreter.rs#L44
warning: this `impl` can be derived
--> python-packaging/src/interpreter.rs:44:1
|
44 | / impl Default for PythonInterpreterProfile {
45 | | fn default() -> Self {
46 | | PythonInterpreterProfile::Isolated
47 | | }
48 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
28 + #[derive(Default)]
29 | pub enum PythonInterpreterProfile {
|
help: ...and mark the default variant
|
34 ~ #[default]
35 ~ Isolated,
|
|
Run actions-rs/clippy@master:
python-packaging/src/interpreter.rs#L50
warning: direct implementation of `ToString`
--> python-packaging/src/interpreter.rs:50:1
|
50 | / impl ToString for PythonInterpreterProfile {
51 | | fn to_string(&self) -> String {
52 | | match self {
53 | | Self::Isolated => "isolated",
... |
57 | | }
58 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `#[warn(clippy::to_string_trait_impl)]` on by default
|
Run actions-rs/clippy@master:
python-packaging/src/interpreter.rs#L138
warning: direct implementation of `ToString`
--> python-packaging/src/interpreter.rs:138:1
|
138 | / impl ToString for TerminfoResolution {
139 | | fn to_string(&self) -> String {
140 | | match self {
141 | | Self::Dynamic => "dynamic".to_string(),
... |
145 | | }
146 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
Run actions-rs/clippy@master:
python-packaging/src/interpreter.rs#L246
warning: direct implementation of `ToString`
--> python-packaging/src/interpreter.rs:246:1
|
246 | / impl ToString for MemoryAllocatorBackend {
247 | | fn to_string(&self) -> String {
248 | | match self {
249 | | Self::Default => "default",
... |
256 | | }
257 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
Run actions-rs/clippy@master:
python-packaging/src/interpreter.rs#L309
warning: direct implementation of `ToString`
--> python-packaging/src/interpreter.rs:309:1
|
309 | / impl ToString for CoerceCLocale {
310 | | fn to_string(&self) -> String {
311 | | match self {
312 | | Self::LCCtype => "LC_CTYPE",
... |
316 | | }
317 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
Run actions-rs/clippy@master:
python-packaging/src/interpreter.rs#L370
warning: direct implementation of `ToString`
--> python-packaging/src/interpreter.rs:370:1
|
370 | / impl ToString for BytesWarning {
371 | | fn to_string(&self) -> String {
372 | | match self {
373 | | Self::None => "none",
... |
378 | | }
379 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
Loading