.github/workflows/workspace.yml #1162
Annotations
10 warnings
Run actions-rs/clippy@master:
tugger-common/src/http.rs#L118
warning: a method with this name may be added to the standard library in the future
--> tugger-common/src/http.rs:118:18
|
118 | lock.unlock().context("unlocking")?;
| ^^^^^^
|
= warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
= note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
= help: call with fully qualified syntax `fs2::FileExt::unlock(...)` to keep using the current method
= note: `#[warn(unstable_name_collisions)]` on by default
|
Run actions-rs/clippy@master:
tugger-common/src/http.rs#L143
warning: a method with this name may be added to the standard library in the future
--> tugger-common/src/http.rs:143:10
|
143 | lock.unlock().context("unlocking")?;
| ^^^^^^
|
= warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
= note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
= help: call with fully qualified syntax `fs2::FileExt::unlock(...)` to keep using the current method
|
Run actions-rs/clippy@master:
python-packed-resources/src/parser.rs#L65
warning: variable does not need to be mutable
--> python-packed-resources/src/parser.rs:65:13
|
65 | let mut state = self.blob_sections[resource_field as usize]
| ----^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
Run actions-rs/clippy@master:
python-packed-resources/src/parser.rs#L516
warning: the following explicit lifetimes could be elided: 'a
--> python-packed-resources/src/parser.rs:516:23
|
516 | pub fn load_resources<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
516 - pub fn load_resources<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
516 + pub fn load_resources(data: &[u8]) -> Result<ResourceParserIterator<'_>, &'static str> {
|
|
Run actions-rs/clippy@master:
python-packed-resources/src/parser.rs#L530
warning: the following explicit lifetimes could be elided: 'a
--> python-packed-resources/src/parser.rs:530:22
|
530 | fn load_resources_v3<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
530 - fn load_resources_v3<'a>(data: &'a [u8]) -> Result<ResourceParserIterator<'a>, &'static str> {
530 + fn load_resources_v3(data: &[u8]) -> Result<ResourceParserIterator<'_>, &'static str> {
|
|
Run actions-rs/clippy@master:
python-packed-resources/src/resource.rs#L120
warning: the following explicit lifetimes could be elided: 'a
--> python-packed-resources/src/resource.rs:120:6
|
120 | impl<'a, X> Default for Resource<'a, X>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
120 - impl<'a, X> Default for Resource<'a, X>
120 + impl<X> Default for Resource<'_, X>
|
|
Run actions-rs/clippy@master:
python-packed-resources/src/writer.rs#L281
warning: needless call to `as_bytes()`
--> python-packed-resources/src/writer.rs:281:36
|
281 | ResourceField::Name => self.name.as_bytes().len(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.name.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
= note: `#[warn(clippy::needless_as_bytes)]` on by default
|
Run actions-rs/clippy@master:
python-packed-resources/src/writer.rs#L323
warning: needless call to `as_bytes()`
--> python-packed-resources/src/writer.rs:323:45
|
323 | .map(|(key, value)| key.as_bytes().len() + value.len())
| ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
|
Run actions-rs/clippy@master:
python-packed-resources/src/writer.rs#L333
warning: needless call to `as_bytes()`
--> python-packed-resources/src/writer.rs:333:45
|
333 | .map(|(key, value)| key.as_bytes().len() + value.len())
| ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
|
Run actions-rs/clippy@master:
python-packed-resources/src/writer.rs#L348
warning: needless call to `as_bytes()`
--> python-packed-resources/src/writer.rs:348:42
|
348 | names.iter().map(|s| s.as_bytes().len()).sum()
| ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
|
Loading