Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run command doesnt propogate app error status in repl mode #208

Closed
jayvdb opened this issue Nov 23, 2019 · 2 comments
Closed

run command doesnt propogate app error status in repl mode #208

jayvdb opened this issue Nov 23, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Nov 23, 2019

When using the run command, if the app fails, the error code is discarded.

c.f. https://dev.azure.com/gregoryszorc/PyOxidizer/_build/results?buildId=275 on #183

@jayvdb jayvdb changed the title run command doesnt propogate app error status run command doesnt propogate app error status in repl mode Nov 23, 2019
@jayvdb
Copy link
Contributor Author

jayvdb commented Nov 23, 2019

Actually this is probably due to using the repl mode, and would also occurr when running the app directly.

It does differ from how the python3 repl works with the cli wrapper.

> echo 'import foobar' | python3
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'foobar'
> echo $?
1

@indygreg indygreg added the bug Something isn't working label Nov 24, 2019
@indygreg
Copy link
Owner

It does not surprise me that the repl mode doesn't handle exit codes properly. Getting things right is hard and I only made an effort to do it for eval and module, which are the modes that matter most.

jayvdb added a commit to jayvdb/PyOxidizer that referenced this issue Nov 25, 2019
jayvdb added a commit to jayvdb/PyOxidizer that referenced this issue Nov 25, 2019
jayvdb added a commit to jayvdb/PyOxidizer that referenced this issue Nov 25, 2019
jayvdb added a commit to jayvdb/PyOxidizer that referenced this issue Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants