Rename PyInit syms to avoid clashes #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please be ruthless in the review; I haven't done much rust so I expect lots of ways this could be improved. At least I think the symbol rename can be avoided if the full name doesnt contain Also I could detect clashes first before enabling symbol renaming, avoiding unnecessary work - that is at least sensible for built executables, but maybe isnt desirable if building a library. |
|
Alwsys rewriting objects breaks and A bug in Looks like we need to only employ this when necessary, to avoid breakages. |
jayvdb
force-pushed
the
static-PyInit-clash
branch
from
efe8df0 to
8b20a7b
Compare
|
The logic now avoids rewriting |
jayvdb
force-pushed
the
static-PyInit-clash
branch
from
8b20a7b to
231ca63
Compare
|
Further avoidance of sym renaming done. = note: /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: /home/jayvdb/pyox/builtext/build/target/x86_64-unknown-linux-gnu/debug/deps/libpyembed-61edb0164b82ba09.rlib(gevent._queue.0.o): in function `__Pyx_modinit_type_init_code':
/tmp/pip-install-j06ct3pk/gevent/src/gevent/queue.c:16637: undefined reference to `__pyx_wrapperbase_6gevent_6_queue_5Queue_20__len__'
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: /tmp/pip-install-j06ct3pk/gevent/src/gevent/queue.c:16702: undefined reference to `__pyx_wrapperbase_6gevent_6_queue_13JoinableQueue___init__'
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: /home/jayvdb/pyox/builtext/build/target/x86_64-unknown-linux-gnu/debug/deps/libpyembed-61edb0164b82ba09.rlib(gevent._queue.0.o):(.debug_info+0x55): undefined reference to `__pyx_wrapperbase_6gevent_6_queue_5Queue_20__len__'
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: /home/jayvdb/pyox/builtext/build/target/x86_64-unknown-linux-gnu/debug/deps/libpyembed-61edb0164b82ba09.rlib(gevent._queue.0.o):(.debug_info+0xe3c): undefined reference to `__pyx_wrapperbase_6gevent_6_queue_13JoinableQueue___init__'Also note I ran into tobgu/pyrsistent#182 , meaning only one of |
jayvdb
force-pushed
the
static-PyInit-clash
branch
from
231ca63 to
d66cc29
Compare
|
Thanks for this patch. I'm probably going to wait on this review until my next serious day of hacking on PyOxidizer because there's a lot to think about here... I'll try to get to your other pull requests tonight though... |
jayvdb
force-pushed
the
static-PyInit-clash
branch
5 times, most recently
from
466743b to
1c89c79
Compare
|
I disabled the Traceback (most recent call last):
File "<string>", line 1, in <module>
File "simplejson", line 134, in <module>
File "simplejson.decoder", line 8, in <module>
File "simplejson.scanner", line 11, in <module>
File "simplejson.scanner", line 7, in _import_c_make_scanner
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xae in position 6387: invalid start byte
|
|
All versions of Rust on macOS 10.13 pass. |
This was referenced Nov 22, 2019
jayvdb
force-pushed
the
static-PyInit-clash
branch
2 times, most recently
from
0d57e4e to
463579d
Compare
jayvdb
force-pushed
the
static-PyInit-clash
branch
from
aa93ab4 to
277b8f9
Compare
jayvdb
force-pushed
the
static-PyInit-clash
branch
2 times, most recently
from
c594a6f to
27e7805
Compare
jayvdb
commented
Nov 29, 2019
This causes the .obj files to be unparsable by editbin, dumpbin, nm, objcopy, goblin and object. Related to indygreg#169
indygreg
force-pushed
the
main
branch
24 times, most recently
from
296b083 to
13e08f6
Compare
indygreg
force-pushed
the
main
branch
3 times, most recently
from
8f998b7 to
5c5ac33
Compare
indygreg
force-pushed
the
main
branch
2 times, most recently
from
5e0524b to
789c62e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built extensions in packages often have common names
like speedups, utils, _objects, cpython, etc. which
reside inside the package namespace.
The compiled extensions each have a
PyInit_<module>which needs to be renamed to
PyInit_<pkg>_<module>to avoid clashes when combined into a static binary.
Fixes #169