Fi 2413 optional groups prioritize pass (#431)

* change priorities for optional groups

* update rspec tests for optional group priorities

* rubocop conformance

dev_suites/dev_infrastructure_test/passing_optional_group.rb

@@ -5,10 +5,16 @@ class PassingOptionalGroup < Inferno::TestGroup
 
     optional
 
-    test 'Test in Optional Group' do
+    test 'Passing test in Optional Group' do
       optional
 
       run { assert true }
     end
+
+    test 'Failing test in Optional Group' do
+      optional
+
+      run { assert false }
+    end
   end
 end

lib/inferno/result_summarizer.rb

@@ -11,6 +11,10 @@ def initialize(results)
     end
 
     def summarize
+      return 'pass' if all_optional_results? &&
+                       unique_result_strings.any?('pass') &&
+                       unique_result_strings.none? { |result| %w[wait running].include? result }
+
       prioritized_result_strings.find { |result_string| unique_result_strings.include? result_string }
     end
 

spec/inferno/dsl/test_creation_spec.rb

@@ -62,7 +62,7 @@
 
         results = results_repo.current_results_for_test_session(test_session.id)
 
-        expect(results.length).to eq(17)
+        expect(results.length).to eq(18)
 
         required_results = results.reject(&:optional?)
         non_passing_results = required_results.reject { |result| result.result == 'pass' }

spec/inferno/result_summarizer_spec.rb

@@ -13,12 +13,12 @@
   end
 
   context 'when all results are optional' do
-    it 'returns the highest priority result' do
+    it 'prioritizes passing over failing when a result passes' do
       allow(passing_result).to receive(:optional?).and_return(true)
       allow(failing_result).to receive(:optional?).and_return(true)
       result = described_class.new([passing_result, failing_result]).summarize
 
-      expect(result).to eq('fail')
+      expect(result).to eq('pass')
     end
   end