Fi 2413 optional groups prioritize pass #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 77.08% 77.09% +0.01%
==========================================
Files 220 220
Lines 10946 10951 +5
Branches 1029 1030 +1
==========================================
+ Hits 8438 8443 +5
Misses 1929 1929
Partials 579 579
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ps-prioritize-pass
lib/inferno/result_summarizer.rb
Outdated
| @@ -11,6 +11,10 @@ def initialize(results) | |||
| end | |||
|
|
|||
| def summarize | |||
| return 'pass' if all_optional_results? && | |||
| unique_result_strings.any?('pass') && | |||
| unique_result_strings.none? { |result| %w[cancel wait running].include? result } | |||
There was a problem hiding this comment.
I don't think cancel belongs here, as the results of the cancelled tests wouldn't prevent the group from passing.
There was a problem hiding this comment.
removed cancel
Jammjammjamm
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If all of a test group's children are optional and at least one child passes the group passes. My exact implementation makes the optional result group priorities (in order): cancel, wait, running, pass, skip, fail, error, omit.
Testing Guidance
Run the infrastructure test suite, where test group 2 now has one passing optional and one failing optional test, with an overall result of pass.
bundle exec rake spectests have also been updated accordingly.