Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor catalog #411

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Refactor catalog #411

merged 7 commits into from
Jan 4, 2024

Conversation

JinHai-CN
Copy link
Contributor

What problem does this PR solve?

  1. Refactor lots of module in catalog into one module: catalog, others are refactored as module partition of catalog.
  2. Unify interface of various 'meta' and 'entry' into catalog. To prepare to use unified command interface to CRUD the catalog.

Add corresponding issue link with summary if exists -->

Issue link: #368

What is changed and how it works?

Code changes

  • Has Code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (knn query performance test)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

…tion

Signed-off-by: jinhai <haijin.chn@gmail.com>
Signed-off-by: jinhai <haijin.chn@gmail.com>
@JinHai-CN JinHai-CN added ci PR can be test and removed ci PR can be test labels Jan 3, 2024
Signed-off-by: jinhai <haijin.chn@gmail.com>
docs/build_from_source.md Outdated Show resolved Hide resolved
@JinHai-CN JinHai-CN requested a review from KKould January 4, 2024 06:16
Signed-off-by: jinhai <haijin.chn@gmail.com>
docs/build_from_source.md Outdated Show resolved Hide resolved
Signed-off-by: jinhai <haijin.chn@gmail.com>
@JinHai-CN
Copy link
Contributor Author

@mergify queue

Copy link

mergify bot commented Jan 4, 2024

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by>=1
      • check-success=tests
  • -draft [📌 queue requirement]
  • -mergify-configuration-changed [📌 queue -> allow_merging_configuration_change setting requirement]

@yingfeng yingfeng removed the request for review from KKould January 4, 2024 13:13
@JinHai-CN JinHai-CN requested review from KKould and removed request for small-turtle-1 and KKould January 4, 2024 13:13
@yingfeng
Copy link
Member

yingfeng commented Jan 4, 2024

@mergify queue

@JinHai-CN JinHai-CN requested a review from KKould January 4, 2024 13:14
Copy link

mergify bot commented Jan 4, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at a264cf0

@JinHai-CN JinHai-CN removed the request for review from KKould January 4, 2024 13:14
@mergify mergify bot merged commit a264cf0 into infiniflow:main Jan 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci PR can be test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants