Rolling Upgrade fails when memcached or RESP endpoint not defined on…

… original cluster. Fixes #2140

pkg/infinispan/upgrades/rolling_upgrades.go

@@ -67,8 +67,8 @@ func ConnectCaches(user, adminPasswordSource, sourceIp string, sourceClient, tar
 }
 
 // SyncCaches Do a sync data operation for each cache in a cluster
-func SyncCaches(targetClient api.Infinispan, logger logr.Logger) error {
-	names, err := cacheNames(targetClient)
+func SyncCaches(sourceClient, targetClient api.Infinispan, logger logr.Logger) error {
+	names, err := cacheNames(sourceClient)
 	if err != nil {
 		return fmt.Errorf("failed to get cache names from the target cluster: %w", err)
 	}

pkg/reconcile/pipeline/infinispan/handler/manage/hotrod_upgrades.go

@@ -474,9 +474,13 @@ func (r *HotRodRollingUpgradeRequest) syncData() error {
 		return fmt.Errorf("failed to obtain pods from the target cluster: %w", err)
 	}
 
+	sourceClient, err := ctx.InfinispanClient()
+	if err != nil {
+		return err
+	}
 	// Clone the source curl client as the credentials are the same, updating the pod to one from the target statefulset
 	targetClient := ctx.InfinispanClientForPod(podList.Items[0].Name)
-	if err = upgrades.SyncCaches(targetClient, r.log); err != nil {
+	if err = upgrades.SyncCaches(sourceClient, targetClient, r.log); err != nil {
 		return err
 	}