Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESP and HotRodMigration test fixes #2144

Merged
merged 1 commit into from
Sep 5, 2024
Merged

RESP and HotRodMigration test fixes #2144

merged 1 commit into from
Sep 5, 2024

Conversation

Crumby
Copy link
Collaborator

@Crumby Crumby commented Sep 4, 2024

Several test fixes to adjust for branding versions, feature availability and different default behavior on OpenShift:

  • TestRollingUpgrade compared a given version to an upstream one, which is incorrectly evaluated in case of brand versioning
  • Redis is available by default starting from 15.0.0
  • Running the tests on the OpenShift makes the cluster encrypted by default but Redis client does not account for that
  • Fix HostAndPort to really have a port in case of Route expose type. Redis will complain on missing port otherwise

@ryanemerson
Copy link
Contributor

@Crumby There are CI failures, please address.

@ryanemerson ryanemerson merged commit 5afa0ef into infinispan:main Sep 5, 2024
1 of 2 checks passed
@ryanemerson
Copy link
Contributor

Thanks @Crumby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanemerson ryanemerson Awaiting requested review from ryanemerson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crumby @ryanemerson