Feature - button type #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadadavorin
approved these changes
Dec 5, 2024
goranalkovic-infinum
requested changes
Dec 5, 2024
| @@ -20,6 +20,10 @@ | |||
| "buttonId": { | |||
| "type": "string" | |||
| }, | |||
| "buttonType": { | |||
| "type": "string", | |||
| "default": "button" | |||
There was a problem hiding this comment.
Suggested change
| "default": "button" | |
| "default": "" |
and don't add the attr if it's empty, and we should be ok 😄
Enables setting a button type as 'submit', any other viable option or a default 'button' if the Button is not a link
piqusy
force-pushed
the
feature/button-type
branch
from
1f62bcb to
cb36884
Compare
goranalkovic-infinum
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables setting a button type as 'submit', any other viable option or a default 'button' if the Button is not a link.
Use-case: using various buttons in a form without implicitly having them as submit type