Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #311

Merged
merged 115 commits into from
Jul 12, 2022
Merged

Merge #311

merged 115 commits into from
Jul 12, 2022

Conversation

iruzevic
Copy link
Member

No description provided.

iruzevic and others added 30 commits May 12, 2022 13:48
Co-authored-by: Davorin Prislin <81157133+dadadavorin@users.noreply.github.com>
Co-authored-by: Davorin Prislin <81157133+dadadavorin@users.noreply.github.com>
…webP

* commit '9a48a20a9255e2256fc6b9bb765cf8a56e121622':
  Apply suggestions from code review
  Update src/Media/AbstractMedia.php

# Conflicts:
#	src/Media/AbstractMedia.php
Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
Co-authored-by: Davorin Prislin <81157133+dadadavorin@users.noreply.github.com>
Co-authored-by: Davorin Prislin <81157133+dadadavorin@users.noreply.github.com>
Add a check if the attribute is missing in the filterBlocksContent method
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #311 (18b5827) into main (8dedc1e) will decrease coverage by 2.47%.
The diff coverage is 83.68%.

@@             Coverage Diff              @@
##               main     #311      +/-   ##
============================================
- Coverage     84.39%   81.92%   -2.48%     
- Complexity      883     1246     +363     
============================================
  Files           110      131      +21     
  Lines          2691     3894    +1203     
============================================
+ Hits           2271     3190     +919     
- Misses          420      704     +284     
Flag Coverage Δ
unittests 81.92% <83.68%> (-2.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/AdminMenus/AdminSubMenuExample.php 0.00% <0.00%> (ø)
src/CustomMeta/AbstractAcfMeta.php 100.00% <ø> (+16.66%) ⬆️
src/CustomPostType/AbstractPostType.php 100.00% <ø> (ø)
src/CustomTaxonomy/AbstractTaxonomy.php 100.00% <ø> (ø)
src/Exception/ComponentException.php 73.33% <0.00%> (-26.67%) ⬇️
src/Exception/InvalidBlock.php 50.00% <0.00%> (-37.10%) ⬇️
src/Helpers/ShortcodeTrait.php 100.00% <ø> (ø)
src/Init/InitAllCli.php 0.00% <0.00%> (ø)
src/Init/InitPluginCli.php 0.00% <0.00%> (ø)
src/Main/AbstractMain.php 56.41% <0.00%> (-7.23%) ⬇️
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 585e4dc...18b5827. Read the comment docs.

@iruzevic iruzevic merged commit 2152c14 into main Jul 12, 2022
iruzevic added a commit that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants