Eliminate usage of removed OTLP LogRecord.Name field #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogRecord.Name is no longer part of the OTLP data model and was deprecated open-telemetry/opentelemetry-proto#357 and deleted open-telemetry/opentelemetry-proto#373 from OTLP. It is now deprecated in the Collector codebase too: https://github.com/open-telemetry/opentelemetry-collector/blob/d2e5601b7045a3021009729ce539cb88373f3216/model/internal/pdata/generated_log.go#L644 We are planning to delete it from the Collector codebase, but first we need to remove the references from this codebase since it is a Collector dependency. Testing done: cd otel2influx && go test ./...
|
@jacobmarble can you please take a look. I think I cleaned it from the right places. Thank you. |
|
I'll take a look at the falling CI tests later, unless you beat me to it. ooo today. |
Closed
|
Thanks for merging @jacobmarble Please ping me when you make a new release here. I will update Otel Collector to use the new version. |
|
Hey @tigrannajaryan, Just so you know, @jacobmarble is on holiday so might take a little longer to respond :) Dom |
|
Thanks @domodwyer |
|
Hey @tigrannajaryan , I'm back from ooo, working on this now. |
|
@tigrannajaryan: v0.2.17 is tagged, with dependency updates to otel 0.48.0 and all deprecation warnings (per staticcheck v2021.1.2) resolved. |
|
Thanks. Collector updated to use v0.2.17: open-telemetry/opentelemetry-collector-contrib#9226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogRecord.Name is no longer part of the OTLP data model and was deprecated
open-telemetry/opentelemetry-proto#357 and
deleted open-telemetry/opentelemetry-proto#373 from OTLP.
It is now deprecated in the Collector codebase too:
https://github.com/open-telemetry/opentelemetry-collector/blob/d2e5601b7045a3021009729ce539cb88373f3216/model/internal/pdata/generated_log.go#L644
We are planning to delete it from the Collector codebase, but first we need
to remove the references from this codebase since it is a Collector dependency.
Testing done: cd otel2influx && go test ./...