Remove deprecated LogRecord.Name field #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field is already deprecated and was on notice to be removed. I removed all usages of the field from the Collector codebase.
jack-berg
approved these changes
Mar 23, 2022
pmm-sumo
approved these changes
Mar 23, 2022
djaglowski
approved these changes
Mar 23, 2022
|
@open-telemetry/collector-approvers @open-telemetry/collector-contrib-approvers FYI. |
jpkrohling
approved these changes
Mar 23, 2022
kumoroku
approved these changes
Mar 23, 2022
|
@open-telemetry/specs-approvers please review. I think I need an approval from specs-approvers to be able to merge. |
yurishkuro
approved these changes
Mar 28, 2022
codeboten
approved these changes
Mar 28, 2022
bogdandrutu
approved these changes
Mar 28, 2022
bogdandrutu
approved these changes
Mar 28, 2022
tigrannajaryan
added a commit
to tigrannajaryan/influxdb-observability
that referenced
this pull request
Apr 1, 2022
LogRecord.Name is no longer part of the OTLP data model and was deprecated open-telemetry/opentelemetry-proto#357 and deleted open-telemetry/opentelemetry-proto#373 from OTLP. It is now deprecated in the Collector codebase too: https://github.com/open-telemetry/opentelemetry-collector/blob/d2e5601b7045a3021009729ce539cb88373f3216/model/internal/pdata/generated_log.go#L644 We are planning to delete it from the Collector codebase, but first we need to remove the references from this codebase since it is a Collector dependency.
tigrannajaryan
added a commit
to tigrannajaryan/influxdb-observability
that referenced
this pull request
Apr 1, 2022
LogRecord.Name is no longer part of the OTLP data model and was deprecated open-telemetry/opentelemetry-proto#357 and deleted open-telemetry/opentelemetry-proto#373 from OTLP. It is now deprecated in the Collector codebase too: https://github.com/open-telemetry/opentelemetry-collector/blob/d2e5601b7045a3021009729ce539cb88373f3216/model/internal/pdata/generated_log.go#L644 We are planning to delete it from the Collector codebase, but first we need to remove the references from this codebase since it is a Collector dependency. Testing done: cd otel2influx && go test ./...
axw
added a commit
to axw/apm-server
that referenced
this pull request
Aug 1, 2022
Adjust code to opentelemetry-collector changes Mostly just adjusting to API changes, but there are some functional changes related to Jaeger span events, and OTLP logs. open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances. open-telemetry/opentelemetry-proto#373 removed the deprecated LogRecord.Name field. There is no replacement, hence we no longer record `event.action`.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field is already deprecated and was on notice to be removed.
I removed all usages of the field from the Collector codebase.