Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop chronyc requirement from documentation and sample configuration #14964

Closed
cschug opened this issue Mar 11, 2024 · 2 comments · Fixed by #14966
Closed

Drop chronyc requirement from documentation and sample configuration #14964

cschug opened this issue Mar 11, 2024 · 2 comments · Fixed by #14966
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@cschug
Copy link
Contributor

cschug commented Mar 11, 2024

Use Case

With release of Telegraf 1.30.0 the dependency on the chronyc binary was dropped in code #14629 but the documentation and the sample configuration still state it's an requirement ("requires chronyc executable") which should be removed, too.

Expected behavior

Sync documentation and sample configuration with code.

Actual behavior

Documentation and sample code do not reflect the latest changes.

Additional info

No response
@cschug cschug added the feature request Requests for new plugin and for new features to existing plugins label Mar 11, 2024
@srebhan
Copy link
Member

srebhan commented Mar 11, 2024

@cschug would you be willing to put this into a pull-request?

cschug added a commit to cschug/telegraf that referenced this issue Mar 11, 2024
@cschug
feat(inputs.chrony): Remove chronyc depdendency in documentation
1d3f163 
This updates the documentation and sample code of the `chrony` input
plugin to reflect the code changes done in PR influxdata#14629 which was dropping
the runtime dependency on a locally installed `chronyc` executable.

Relates to influxdata#14629.
Fixes influxdata#14964.
@cschug cschug mentioned this issue Mar 11, 2024
Merged
1 task
@cschug
Copy link
Contributor Author

cschug commented Mar 11, 2024

@srebhan sure, it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(inputs.chrony): Remove chronyc depdendency in documentation cschug/telegraf
2 participants
@cschug @srebhan