Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.chrony): Remove chronyc dependency #14629

Merged
merged 4 commits into from
Feb 1, 2024
Merged

feat(inputs.chrony): Remove chronyc dependency #14629

merged 4 commits into from
Feb 1, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jan 25, 2024 •
edited
Loading

Summary

This PR removes the dependency for chronyc to be installed in preparation of tackling #2798. That change now also allows to check remote chrony daemons if they are configured to allow this (see bindcmdaddress and cmdallow of chronyd documentation).

Furthermore, we do add an integration test against a chrony docker container and improve the non-integration test.

Checklist

  • No AI generated code was used in this PR

Related issues

related to #2798

@telegraf-tiger telegraf-tiger bot added chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 25, 2024
@srebhan srebhan changed the title chore(inputs.chrony): Add integration test test(inputs.chrony): Add integration test Jan 25, 2024
@srebhan srebhan added test and removed chore labels Jan 25, 2024
@srebhan srebhan force-pushed the chrony_integration_test branch from 310e6bd to 3cbd286 Compare January 26, 2024 12:26
@srebhan srebhan changed the title test(inputs.chrony): Add integration test feat(inputs.chrony): Remove chronyc dependency Jan 26, 2024
@srebhan srebhan added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin and removed test labels Jan 26, 2024
@srebhan srebhan mentioned this pull request Jan 26, 2024
Closed
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 26, 2024
powersj
powersj reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool, thanks for the integration test too!

plugins/inputs/chrony/chrony.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

powersj
powersj approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landing after playing with this locally.

@powersj powersj merged commit 1201675 into influxdata:master Feb 1, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Feb 1, 2024
@cschug cschug mentioned this pull request Mar 11, 2024
Closed
cschug added a commit to cschug/telegraf that referenced this pull request Mar 11, 2024
@cschug
feat(inputs.chrony): Remove chronyc depdendency in documentation
1d3f163 
This updates the documentation and sample code of the `chrony` input
plugin to reflect the code changes done in PR influxdata#14629 which was dropping
the runtime dependency on a locally installed `chronyc` executable.

Relates to influxdata#14629.
Fixes influxdata#14964.
@cschug cschug mentioned this pull request Mar 11, 2024
Merged
1 task
@powersj powersj mentioned this pull request Jun 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

Assignees

@powersj powersj

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@srebhan @powersj