fix(inputs.tail): Prevent deadlock when closing and max undelivered lines hit #15649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we try to close the tailer, tail will block until the goroutine is in a dead state. When a tailer had read more than the max undelivered this condition was never hit and we deadlocked. This ensures that when the tailer is trying to die we clear out the channel to close successfully.
This was not an issue when the max undelivered was not hit.
Checklist
Related issues
fixes: #15641