Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit the evidence detected by Hermes to all clients of the misbehaving chain #3223

Closed
5 tasks
Tracked by #3175
ancazamfir opened this issue Apr 4, 2023 · 0 comments · Fixed by #3456
Closed
5 tasks
Tracked by #3175

Submit the evidence detected by Hermes to all clients of the misbehaving chain #3223

ancazamfir opened this issue Apr 4, 2023 · 0 comments · Fixed by #3456
Assignees
Labels
O: misbehaviour Objective: related to misbehaviour detection
Milestone

Comments

@ancazamfir
Copy link
Collaborator

Summary

Submit evidence detected by Hermes to all clients of the misbehaving chain

Problem Definition

When a chain misbehaves, IBC evidence is not submitted to all clients for that chain, just for the client that was updated with the conflicting header.
Because of this some clients for the misbehaving chain might be frozen late or not at all.

Proposal

Currently, with this configuration

[mode.clients]
misbehaviour = true

hermes monitors headers in MsgUpdateClient events for active clients and validates them against the chain's full node headers. In case of misbehaviour, hermes submits MsgSubmitMisbehaviour to the respective client and the client is then frozen.

We should attempt to submit the evidence to all clients of the misbehaving chains. Note that since different clients for a chain may have different security parameters, the conflicting header might not verify for other clients. In this case the relayer should skip the evidence submission.

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: misbehaviour Objective: related to misbehaviour detection
Projects
Status: ✅ Done
3 participants