Add `evidence` command for monitoring and reporting misbehavior evidence to counterparty clients #3456

romac · 2023-06-28T12:52:19Z

Closes: #3223
Closes: #3219

TODO

Depends on Update tendermint-rs to v0.34, prost to v0.12 and tonic to v0.10 #3651

PR author checklist:

Added changelog entry, using unclog.
Added tests: integration (for Hermes) or unit/mock tests (for modules).
Linked to GitHub issue.
Updated code comments and documentation (e.g., docs/).
Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

Reviewed Files changed in the GitHub PR explorer.
Manually tested (in case integration/unit/mock tests are absent).

…behaviour-handling` branch

…aving chain

crates/relayer-cli/src/commands/evidence.rs

ancazamfir · 2023-07-10T09:25:21Z

I added some testing instructions at here.
The last step, running the new evidence CLI, currently fails due to missing client updates.

Signed-off-by: Romain Ruetschi <romain@informal.systems>

* Add clock-drift.md file to guide * Add section on mis-configuring clock drift * Update guide/src/advanced/troubleshooting/clock-drift.md Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Sean Chen <seanchen11235@gmail.com> * Update guide/src/advanced/troubleshooting/clock-drift.md Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Sean Chen <seanchen11235@gmail.com> * Remove redundant section * Update guide/src/advanced/troubleshooting/clock-drift.md Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Sean Chen <seanchen11235@gmail.com> * Update guide/src/advanced/troubleshooting/clock-drift.md Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Sean Chen <seanchen11235@gmail.com> * Explain what `C` constant represents * Add reference to forward lunatic attack --------- Signed-off-by: Sean Chen <seanchen11235@gmail.com> Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>

Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.3.3 to 1.4.0. - [Release notes](https://github.com/uuid-rs/uuid/releases) - [Commits](uuid-rs/uuid@1.3.3...1.4.0) --- updated-dependencies: - dependency-name: uuid dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

The MsgTimeoutOnClose requires sequence of dstchannel.NextRecv in ordered channels, rather than packet.Sequence. The code above resolve the sequence for ordered and unordered, just while creating msg it is ignored. Signed-off-by: Puneet <59960662+puneet2019@users.noreply.github.com>

…es to relay from the operational data (#3468) * Include client updates for supporting messages when assembling messages to relay from the operational data * Add changelog entry

* Use max_block_time queried from /genesis * Clean solution * Add unclog entry * Remove serde-with dependency

…error (#3466) * Stub out code flow * Stub out code flow * Change return type of `hermes_cofig` fn * Define ConfigAutoError type * Add some printlns * Change `get_configs` return type * Change AutoCmd::run * Get it to compile * Fix false reporting of missing chain configs * Change get_data_from_handles * Get it working * Remove some debugging code * Cargo fmt * Update `get_configs` doc comment * Update gas price warning in guide * Cargo fmt

…id freezing the client too early

…ready frozen

romac · 2023-10-16T14:00:08Z

If client is alreadyt frozen we can check if the common height consensus state is already on-chain and in that case just submit the ICS evidence.

9cb4d3e

I wonder if we do actually need to submit the regular misbehavior evidence or if we should only submit the ICS one?

ea73fc0

crates/relayer-cli/src/commands/evidence.rs

ancazamfir · 2023-10-16T18:06:56Z

crates/relayer-cli/src/commands/evidence.rs

+        return Ok(());
+    }
+
+    let mut msgs = match counterparty_client.wait_and_build_update_client(common_height) {


Should we update client if provider_has_common_consensus_state?

I had missed that, good catch! No need indeed, since the provider already has that consensus state.

Can we do the same for sovereign chains? i.e. rename provider_has_common_consensus_state to counterparty_has_common_consensus_state and drop the counterparty_is_provider check from its definition. Then, if true, skip client update for both provider and sovereign chain as well.

Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Romain Ruetschi <github@romac.me>

…consensus state

…on height, whether or not it is a provider chain

crates/relayer-cli/src/commands/evidence.rs

…ovider

ancazamfir

Yayy! Amazing work @romac!

ancazamfir and others added 11 commits June 21, 2023 10:21

evidence worker PoC for testing

ab01656

Cleanup

0d6df8d

Use ibc-proto branch with new provider message

1709d1a

Add MsgSubmitIcsConsumerMisbehaviour domain type from `anca/ics-mis…

fc3aea4

…behaviour-handling` branch

Report misbehavior evidence to all counterparty clients of the misbeh…

81ef9dd

…aving chain

Cleanup

db9187e

Submit CCV misbehaviour if needed

2fa3287

Cleanup

700521f

Check if counterparty is CCV provider

ffc6d67

Cleanup

1e85c83

Add comment

9f965aa

ancazamfir reviewed Jun 30, 2023

View reviewed changes

crates/relayer-cli/src/commands/evidence.rs Outdated Show resolved Hide resolved

ancazamfir added 2 commits July 10, 2023 10:59

Set proposer address in header2

b6605d9

Prepend client updates - work in progress

9de7224

romac and others added 15 commits July 14, 2023 09:30

Increase the timeout on CI (#3436)

93c81b4

Improve some messages in config auto (#3438)

d4e73ce

Update Data-Requirements.md

a4b7767

Signed-off-by: Romain Ruetschi <romain@informal.systems>

Update Data-Requirements.md

49f8ac1

Signed-off-by: Romain Ruetschi <romain@informal.systems>

Add CCV chain bootstrap to CI with Neutron and Gaia (#3451)

84b59e0

Bump serde from 1.0.164 to 1.0.166 (#3458)

75ec1b3

Bump async-trait from 0.1.68 to 0.1.69 (#3459)

7854b2c

Bump erased-serde from 0.3.25 to 0.3.26 (#3460)

cfd005b

Include client updates for supporting messages when assembling messag…

a929e05

…es to relay from the operational data (#3468) * Include client updates for supporting messages when assembling messages to relay from the operational data * Add changelog entry

Use max_expected_time_per_block value for the max_block_time (#3467)

71d5f30

* Use max_block_time queried from /genesis * Clean solution * Add unclog entry * Remove serde-with dependency

Merge branch 'master' into anca/evidene_worker_poc

5846cb9

romac added 4 commits October 13, 2023 14:41

WIP: Use Rust light client to report evidence

6da442a

WIP: Use Go light client to detect misbehaviour

f1b83fe

Issue error when evidence is emitted at forked height

136e25b

Detect and report misbehaviour using the CometBFT light client to avo…

8bfb121

…id freezing the client too early

romac marked this pull request as ready for review October 13, 2023 15:59

Add test for when the client is frozen already by the relayer

2300d6c

romac requested a review from ancazamfir October 16, 2023 12:20

Only send the ICS misbehaviour message when the provider client is al…

ea73fc0

…ready frozen

ancazamfir reviewed Oct 16, 2023

View reviewed changes

crates/relayer-cli/src/commands/evidence.rs Outdated Show resolved Hide resolved

Better cache frozen status of client

d39546d

ancazamfir reviewed Oct 16, 2023

View reviewed changes

crates/relayer-cli/src/commands/evidence.rs Outdated Show resolved Hide resolved

ancazamfir reviewed Oct 16, 2023

View reviewed changes

romac and others added 3 commits October 16, 2023 21:13

Never send IBC message if client is already frozen

78e2ed7

Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Signed-off-by: Romain Ruetschi <github@romac.me>

No need to submit client update if provider chain already has common …

3e8b37f

…consensus state

Abort early if there are no messages to send

530a979

romac requested a review from ancazamfir October 16, 2023 19:19

romac added 4 commits October 16, 2023 21:36

Update comment

992afc3

Update double sign test

4c3a8ad

Skip UpdateClient message if counterparty has consensus state at comm…

c27b9e4

…on height, whether or not it is a provider chain

Improve logs a little bit

116f141

romac commented Oct 17, 2023

View reviewed changes

crates/relayer-cli/src/commands/evidence.rs Outdated Show resolved Hide resolved

sainoe self-requested a review October 17, 2023 11:45

sainoe approved these changes Oct 17, 2023

View reviewed changes

romac added 3 commits October 17, 2023 15:38

Small refactor

c72a270

Check that counterparty client id matches the CCV client id on the pr…

78c1792

…ovider

Create a dummy connection to exercise the provider detection code

c58c119

ancazamfir approved these changes Oct 18, 2023

View reviewed changes

romac merged commit db50666 into master Oct 18, 2023
42 checks passed

romac deleted the anca/evidene_worker_poc branch October 18, 2023 17:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `evidence` command for monitoring and reporting misbehavior evidence to counterparty clients #3456

Add `evidence` command for monitoring and reporting misbehavior evidence to counterparty clients #3456

romac commented Jun 28, 2023 •

edited

Loading

ancazamfir commented Jul 10, 2023

romac commented Oct 16, 2023 •

edited

Loading

ancazamfir Oct 16, 2023

romac Oct 16, 2023

romac Oct 16, 2023

ancazamfir Oct 16, 2023

ancazamfir left a comment

Add evidence command for monitoring and reporting misbehavior evidence to counterparty clients #3456

Add evidence command for monitoring and reporting misbehavior evidence to counterparty clients #3456

Conversation

romac commented Jun 28, 2023 • edited Loading

TODO

PR author checklist:

Reviewer checklist:

ancazamfir commented Jul 10, 2023

romac commented Oct 16, 2023 • edited Loading

ancazamfir Oct 16, 2023

Choose a reason for hiding this comment

romac Oct 16, 2023

Choose a reason for hiding this comment

romac Oct 16, 2023

Choose a reason for hiding this comment

ancazamfir Oct 16, 2023

Choose a reason for hiding this comment

ancazamfir left a comment

Choose a reason for hiding this comment

Add `evidence` command for monitoring and reporting misbehavior evidence to counterparty clients #3456

Add `evidence` command for monitoring and reporting misbehavior evidence to counterparty clients #3456

romac commented Jun 28, 2023 •

edited

Loading

romac commented Oct 16, 2023 •

edited

Loading