Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny uses of unwrap and panic! in non-test code (second pass) #987

Closed
5 of 10 tasks
adizere opened this issue May 25, 2021 · 0 comments
Closed
5 of 10 tasks

Deny uses of unwrap and panic! in non-test code (second pass) #987

adizere opened this issue May 25, 2021 · 0 comments
Labels
O: code-hygiene Objective: cause to improve code hygiene
Milestone
Backlog

Comments

@adizere
Copy link
Member

adizere commented May 25, 2021 •
edited by romac
Loading

Crates

In order of priority:

  • ibc
  • ibc-relayer
  • ibc-telemetry
  • ibc-rest
  • ibc-relayer-cli

Summary

Follow-up to #871, which took care of some of unwraps in crates ibc and relayer.

Acceptance Criteria

Enable #![cfg_attr(not(test), deny(clippy::unwrap_used))]

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added the O: code-hygiene Objective: cause to improve code hygiene label May 25, 2021
@adizere adizere added this to the 06.2021 milestone May 25, 2021
@adizere adizere mentioned this issue May 25, 2021
Merged
2 tasks
@adizere adizere modified the milestones: 06.2021, 07.2021 Jun 28, 2021
@adizere adizere modified the milestones: 07.2021, 10.2021 Aug 3, 2021
@adizere adizere modified the milestones: 10.2021, Backlog Nov 2, 2021
@romac romac changed the title Deny uses of unwrap in non-test code (second pass) Deny uses of unwrap and panic! in non-test code (second pass) Nov 3, 2021
@seanchen1991 seanchen1991 mentioned this issue Nov 3, 2021
Merged
5 tasks
@romac romac removed their assignment Dec 1, 2021
@adizere adizere modified the milestones: Backlog, v1.3 Nov 25, 2022
@adizere adizere added this to Hermes Dec 13, 2022
@adizere adizere moved this to 🆕 New in Hermes Dec 13, 2022
@adizere adizere moved this from 🆕 New to 📋 Backlog in Hermes Dec 13, 2022
@seanchen1991 seanchen1991 modified the milestones: v1.3, Backlog Dec 13, 2022
@romac romac closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Hermes Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O: code-hygiene Objective: cause to improve code hygiene
Projects
Hermes
Status: ✅ Done
Milestone
Backlog
Development

No branches or pull requests
3 participants
@romac @adizere @seanchen1991