Deny uses of .unwrap() in non-test code (first pass)
#850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
commented
Apr 29, 2021
modules/src/application/ics20_fungible_token_transfer/msgs/transfer.rs
Outdated
Show resolved
Hide resolved
- Replaced the `impl From<Infallible> for Kind` block with `trait UnwrapInfallible` following the approach of crate unwrap-infallible. - H/T @romac for the guidance.
This comment has been minimized.
This comment has been minimized.
adizere
changed the title
.unwrap() in non-test code.unwrap() in non-test code (first pass)
adizere
approved these changes
May 25, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…ms#850) * Deny uses of `.unwrap()` in non-test code * Infallible error case for Height conversion. Cleaned unwraps in transfer.rs. * More unwrap fixes in modules & lazy ok_or. * Added simpler approach for converting from a Result<_, Infallible>. - Replaced the `impl From<Infallible> for Kind` block with `trait UnwrapInfallible` following the approach of crate unwrap-infallible. - H/T @romac for the guidance. * More unwrap fixes * More unwrap fixes * Permit unwraps again. Add TODO note * Changelog, permit unwrap in relayer and added TODO * FMT Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #871
unwrapfrom crateibc(@adizere) done ~50%, rest will be handled later, in Deny uses ofunwrapandpanic!in non-test code (second pass) #987unwrapfrom crateibc_relayer(@romac) deferred to later, Deny uses ofunwrapandpanic!in non-test code (second pass) #987