Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade prost and prost-types to version 0.8.0 and tonic to version 0.5.0 #1166

Closed
wants to merge 5 commits into from

Conversation

romac
Copy link
Member

@romac romac commented Jul 9, 2021

Closes: #1161

Depends on informalsystems/tendermint-rs#926

Description

  • Upgrade prost and prost-types to version 0.8.0
  • Upgrade tonic to version 0.5.0

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac requested review from adizere and ancazamfir as code owners July 9, 2021 14:23
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a brief look and it's not clear why tests are failing.

I would have a slight preference for trying to do the release prior to merging this PR (despite the security warning around prost), and we'll figure out the CI failures later next week.

(As a minor point, it may also be desirable to postpone changes around .proto files because there's a parallel PR changing all .proto files -- #948) .

@adizere
Copy link
Member

adizere commented Jul 12, 2021

One more idea --

what if we just update the deps without regenerating the .proto files? That will make the PR easier to review and hopefully E2E tests will pass!

@romac romac force-pushed the romac/prost-0.8 branch from e93b9c7 to d07b4e8 Compare July 13, 2021 10:21
@romac
Copy link
Member Author

romac commented Jul 13, 2021

what if we just update the deps without regenerating the .proto files? That will make the PR easier to review and hopefully E2E tests will pass!

Unfortunately, we cannot do that because the Rust code generated by Prost 0.7 is not forward-compatible with Prost 0.8.

@romac
Copy link
Member Author

romac commented Jul 13, 2021

Looks like we are not receiving any events via the WS subscription anymore, ie. hermes listen ibc-[0|1] does not output anything.

@romac
Copy link
Member Author

romac commented Jul 13, 2021

@thanethomson and I suspect that much of the breakage here and in tendermint-rs is due to a number of regressions in prost 0.8, notably this one.

Marking this PR as blocked until that happens.

@romac romac added the A: blocked Admin: blocked by another (internal/external) issue or PR label Jul 13, 2021
@adizere adizere mentioned this pull request Aug 3, 2021
5 tasks
@romac romac self-assigned this Aug 4, 2021
@romac romac marked this pull request as draft August 10, 2021 09:58
@romac
Copy link
Member Author

romac commented Oct 12, 2021

Superseded by #1451.

@romac romac closed this Oct 12, 2021
@romac romac deleted the romac/prost-0.8 branch October 12, 2021 13:16
@romac romac mentioned this pull request Oct 27, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2021-0073: Conversion from prost_types::Timestamp to SystemTime can cause an overflow and panic
2 participants