-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade prost
and prost-types
to version 0.8.0 and tonic
to version 0.5.0
#1166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a brief look and it's not clear why tests are failing.
I would have a slight preference for trying to do the release prior to merging this PR (despite the security warning around prost), and we'll figure out the CI failures later next week.
(As a minor point, it may also be desirable to postpone changes around .proto files because there's a parallel PR changing all .proto files -- #948) .
One more idea -- what if we just update the deps without regenerating the .proto files? That will make the PR easier to review and hopefully E2E tests will pass! |
Unfortunately, we cannot do that because the Rust code generated by Prost 0.7 is not forward-compatible with Prost 0.8. |
Looks like we are not receiving any events via the WS subscription anymore, ie. |
@thanethomson and I suspect that much of the breakage here and in tendermint-rs is due to a number of regressions in Marking this PR as |
Superseded by #1451. |
Closes: #1161
Description
prost
andprost-types
to version 0.8.0tonic
to version0.5.0
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.