Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prost and prost-types to version 0.8 #926

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Conversation

romac
Copy link
Member

@romac romac commented Jul 9, 2021

Closes: #925

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

Codecov Report

Merging #926 (ee16e7c) into master (7b84781) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #926     +/-   ##
========================================
- Coverage    70.6%   70.4%   -0.2%     
========================================
  Files         203     203             
  Lines       16242   16278     +36     
========================================
+ Hits        11469   11470      +1     
- Misses       4773    4808     +35     
Impacted Files Coverage Δ
tendermint/src/time.rs 93.2% <100.0%> (ø)
tendermint/src/moniker.rs 70.0% <0.0%> (-30.0%) ⬇️
tendermint/src/vote/power.rs 58.1% <0.0%> (-4.4%) ⬇️
tendermint/src/config.rs 64.3% <0.0%> (-1.6%) ⬇️
abci/src/server.rs 9.8% <0.0%> (-0.8%) ⬇️
light-client/src/macros.rs 10.3% <0.0%> (-0.1%) ⬇️
light-client/src/errors.rs 3.0% <0.0%> (ø)
light-client/src/types.rs 30.7% <0.0%> (+0.6%) ⬆️
testgen/src/header.rs 78.8% <0.0%> (+0.6%) ⬆️
testgen/src/vote.rs 84.6% <0.0%> (+0.8%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b84781...ee16e7c. Read the comment docs.

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛅 🐑 🌫 ☀️

@xla
Copy link
Contributor

xla commented Jul 9, 2021

Wondering what's going on with the docs check.

@romac
Copy link
Member Author

romac commented Jul 9, 2021

Wondering what's going on with the docs check.

Looks like a transient issue, will re-run the jobs.

@romac romac merged commit 1efe42c into master Jul 9, 2021
@romac romac deleted the romac/prost-0.8 branch July 9, 2021 14:28
tzemanovic pushed a commit to heliaxdev/tendermint-rs that referenced this pull request Jul 13, 2021
* Update prost to 0.8

* Update `tendermint::time::Time`'s `TryFrom<prost_types::Timestamp>` instance

* Add changelog entry
thanethomson added a commit that referenced this pull request Jul 13, 2021
This temporarily reverts commit
1efe42c. We'll reintroduce these
changes when tokio-rs/prost#502 is fixed.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Jul 13, 2021
This temporarily reverts commit
1efe42c. We'll reintroduce these
changes when tokio-rs/prost#502 is fixed.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2021-0073: Conversion from prost_types::Timestamp to SystemTime can cause an overflow and panic
3 participants