Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion to Protocol Buffers of ClientState's frozen_height field #1711

Merged
merged 4 commits into from
Jan 6, 2022

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Dec 22, 2021

Closes: cosmos/ibc-rs#62

Description

The fix in #1640 was incomplete, so we basically needed to make sure that we serialize domain type frozen height None as Some(Height::zero()), because that's what ibc-go expects.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@hu55a1n1 hu55a1n1 marked this pull request as ready for review December 22, 2021 20:46
@hu55a1n1
Copy link
Member Author

To test with basecoin-rs ->

  1. Checkout the hu55a1n1/module-verification branch
  2. Apply the following diff to disable connection proof verification (that I'm yet to fix) ->
diff --git a/modules/src/core/ics03_connection/handler/verify.rs b/modules/src/core/ics03_connection/handler/verify.rs
index 917fb5ac..e6485ef6 100644
--- a/modules/src/core/ics03_connection/handler/verify.rs
+++ b/modules/src/core/ics03_connection/handler/verify.rs
@@ -16,17 +16,17 @@ pub fn verify_proofs(
     client_state: Option<AnyClientState>,
     height: Height,
     connection_end: &ConnectionEnd,
-    expected_conn: &ConnectionEnd,
+    _expected_conn: &ConnectionEnd,
     proofs: &Proofs,
 ) -> Result<(), Error> {
-    verify_connection_proof(
-        ctx,
-        height,
-        connection_end,
-        expected_conn,
-        proofs.height(),
-        proofs.object_proof(),
-    )?;
+    // verify_connection_proof(
+    //     ctx,
+    //     height,
+    //     connection_end,
+    //     expected_conn,
+    //     proofs.height(),
+    //     proofs.object_proof(),
+    // )?;
 
     // If the message includes a client state, then verify the proof for that state.
     if let Some(expected_client_state) = client_state {
  1. Try to create a connection between the basecoin chain and a gaia chain using these instructions -> Phase4 basecoin-rs#20 (comment)

@romac romac changed the title Fix frozen-height conversion Fix conversion to Protocol Buffers of ClientState's frozen_height field Jan 6, 2022
@romac romac merged commit 0b2ded8 into master Jan 6, 2022
@romac romac deleted the hu55a1n1/1710-fix-frozen-height-conversion branch January 6, 2022 11:28
hu55a1n1 added a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
… field (informalsystems#1711)

* Fix frozen-height conversion

* Add changelog entry

* Clippy happy

* Update changelog

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnOpenAck verification failure
2 participants