Verify the client consensus proof against the client's consensus state root and not the host's state root #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test, follow the instructions in cosmos/ibc-rs#61. Note: the changes in PR #1711 are required to make this work. |
3 tasks
romac
changed the title
romac
reviewed
Jan 6, 2022
.changelog/unreleased/bug-fixes/ibc/1745-fix-consensus-proof-verification.md
Outdated
Show resolved
Hide resolved
romac
approved these changes
Jan 6, 2022
hu55a1n1
added a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…e root and not the host's state root (informalsystems#1746) * Fix consensus proof verification * Add changelog entry * Update changelog * Re-add lost changelog entry Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: cosmos/ibc-rs#61
Description
Client consensus proof verification must be performed against the client's consensus state root and not the host's state root. This was a bug in our impl.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.