Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to abscissa 0.6.0-rc.0 and clap 3.0 #1777

Merged
merged 6 commits into from
Jan 18, 2022
Merged

Update to abscissa 0.6.0-rc.0 and clap 3.0 #1777

merged 6 commits into from
Jan 18, 2022

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Jan 17, 2022 •
edited
Loading

Closes: #1752

Description

Mostly trivial changes to update to the stable API of clap 3.0

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@mzabaluev mzabaluev added I: CLI Internal: related to the relayer's CLI I: dependencies Internal: related to dependencies labels Jan 17, 2022
@mzabaluev mzabaluev mentioned this pull request Jan 17, 2022
Closed
5 tasks
@mzabaluev
Copy link
Contributor Author

Waiting for the next release of modelator including informalsystems/modelator#163 before this can be undrafted with a proper version dependency.

@mzabaluev
Copy link
Contributor Author

The md-link-check failure is fixed by #1778.

@mzabaluev mzabaluev marked this pull request as ready for review January 17, 2022 15:27
@mzabaluev
Derive clap::Parser on ListenCmd
d124ac3 
No need in custom trait implementations now that multiple_occurrences
is properly supported for Vec options.
romac
romac approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this update :)

@romac romac merged commit 242a9ff into master Jan 18, 2022
@romac romac deleted the mikhail/update-abscissa-and-clap-3 branch January 18, 2022 09:43
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@mzabaluev @romac
Update to abscissa 0.6.0-rc.0 and clap 3.0 (informalsystems#1777)
0224dbe 
* Update to abscissa 0.6.0-rc.0 and clap 3.0

* Changelog entry for informalsystems#1777

* Update modelator to 0.4.2

* Derive clap::Parser on ListenCmd

No need in custom trait implementations now that multiple_occurrences
is properly supported for Vec options.

* Fix case in command description

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
I: CLI Internal: related to the relayer's CLI I: dependencies Internal: related to dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to abscissa 0.6.0-rc.0
2 participants
@mzabaluev @romac