Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send MsgAcknowledgment if channel is closed #795

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Conversation

cezarad
Copy link
Contributor

@cezarad cezarad commented Apr 3, 2021

Closes: #675


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@cezarad cezarad requested review from ancazamfir and romac as code owners April 3, 2021 05:41
@cezarad cezarad requested a review from adizere April 3, 2021 05:41
@romac romac changed the title fix #675 MsgAcknowledgment Don't send MsgAcknowledgment if channel is closed Apr 7, 2021
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@romac romac merged commit 193f10e into master Apr 7, 2021
@romac romac deleted the bug_msg_ack branch April 7, 2021 15:45
@adizere adizere mentioned this pull request Apr 8, 2021
5 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Update link.rs

* Update changelog

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't send MsgAcknowledgment if channel is closed
3 participants