Reinstate confio/ics23 dependency #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c195571. I mistakenly took the "11.2" in the CI key name to mean the version of cargo audit being used. This wasn't the case so reverting the change.
This comment has been minimized.
This comment has been minimized.
romac
reviewed
Apr 26, 2021
romac
reviewed
Apr 26, 2021
romac
approved these changes
Apr 27, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Reinstating dep ics23. Remove audit ignore exception from CI. * Disable cron schedule * Added dev branch for CI trigger * Remove dev branch trigger. * Bump up cargo-audit version to 0.14 * Revert "Bump up cargo-audit version to 0.14" This reverts commit c195571. I mistakenly took the "11.2" in the CI key name to mean the version of cargo audit being used. This wasn't the case so reverting the change. * Adding back the scheduled job to ensure daily audits. * Bump audit-check version * Added new type ProofSpecs. Proof spec for cosmos imported from crate ics23. * Added GH issue * changelog * Fix unwrap * Safety note for conversion * Propagate Protobuf decoding error in `convert_tm_to_ics_merkle_proof` Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: cosmos/ibc-proto-rs#9
Description
For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.