Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps to Tokio 1.0 #527

Closed
5 tasks done
adizere opened this issue Jan 15, 2021 · 0 comments · Fixed by #534
Closed
5 tasks done

Upgrade deps to Tokio 1.0 #527

adizere opened this issue Jan 15, 2021 · 0 comments · Fixed by #534
Assignees
Labels
I: dependencies Internal: related to dependencies O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@adizere
Copy link
Member

adizere commented Jan 15, 2021

Crate

relayer and cli

Summary

We previously attempted to upgrade to tokio 0.3 which lead to a dep hell so that change was reverted.

It seems the ecosystem (tonic, hyper) are now ready for Tokio 1.0, so we'll consider doing that soon. This would help with (1) a better (cleaner) runtime, and (2) cleaner use of block_on which is linked to performance issues (more context in the comment linked below).

We cannot remove it everywhere as depending on the caller stack we may end up with runtime-in-a-runtime error. Let's hope this will be cleaner when we migrate to tokio1.0

Originally posted by @ancazamfir in #515 (comment)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added O: new-feature Objective: cause to add a new feature or support I: dependencies Internal: related to dependencies labels Jan 15, 2021
@adizere adizere added this to the v0.1.0 milestone Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: dependencies Internal: related to dependencies O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants