Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpc] crate follow-ups #339

Closed
3 tasks done
xla opened this issue Jun 17, 2020 · 4 comments
Closed
3 tasks done

[rpc] crate follow-ups #339

xla opened this issue Jun 17, 2020 · 4 comments
Labels

Comments

@xla
Copy link
Contributor

xla commented Jun 17, 2020

As leftovers from #338 we need to address to main points

@xla xla added enhancement New feature or request serialization rpc labels Jun 17, 2020
@xla xla changed the title RPC crate follow-ups [rpc] crate follow-ups Jun 18, 2020
@xla xla self-assigned this Jun 18, 2020
@yihuang
Copy link
Contributor

yihuang commented Jun 18, 2020

It seems keeping the endpoint data types inside tendermint crate, can also help keeping the serializers private.
feature guarding is good too.

xla added a commit that referenced this issue Jun 18, 2020
Guard client code paths To avoid the transient dependency on net related
crates for users who are primarily interested in the core types.

Follow-up #339
Ref #337
liamsi pushed a commit that referenced this issue Jun 18, 2020
Guard client code paths To avoid the transient dependency on net related
crates for users who are primarily interested in the core types.

Follow-up #339
Ref #337
@liamsi liamsi mentioned this issue Jun 19, 2020
5 tasks
@liamsi
Copy link
Member

liamsi commented Jun 20, 2020

It seems keeping the endpoint data types inside tendermint crate, can also help keeping the serializers private.

@yihuang from your point of view and keeping the serializer helper methods aside, are their other good reasons to keep the rpc endpoints (or the whole module) inside the tendermint crate?

@yihuang
Copy link
Contributor

yihuang commented Jun 20, 2020

It seems keeping the endpoint data types inside tendermint crate, can also help keeping the serializers private.

@yihuang from your point of view and keeping the serializer helper methods aside, are their other good reasons to keep the rpc endpoints (or the whole module) inside the tendermint crate?

I don't have other reasons for that, I think feature guarding is good too ;D

@ebuchman
Copy link
Member

Given all the recent serialization work, can we close this @thanethomson @greg-szabo ?

@xla xla removed their assignment Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants