Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: guard client with feature flag #343

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

xla
Copy link
Contributor

@xla xla commented Jun 18, 2020

Guard client code paths To avoid the transient dependency on net related crates for users who are primarily interested in the core types.

Follow-up #339
Ref #337

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

Guard client code paths To avoid the transient dependency on net related
crates for users who are primarily interested in the core types.

Follow-up #339
Ref #337
@xla xla added enhancement New feature or request dependencies Pull requests that update a dependency file rpc labels Jun 18, 2020
@xla xla self-assigned this Jun 18, 2020
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamsi liamsi merged commit 81f7eb3 into master Jun 18, 2020
@xla xla deleted the xla/339-feature-guard-client branch June 18, 2020 20:39
@xla
Copy link
Contributor Author

xla commented Jun 18, 2020

@yihuang Does this approach work for your use-case?

@liamsi liamsi mentioned this pull request Jun 19, 2020
5 tasks
liamsi added a commit that referenced this pull request Jun 19, 2020
 - add summary
 - include references only once to make
 changelog more readable
 - add #343
 - rephrase some
 - consistent refs ([#num])
liamsi added a commit that referenced this pull request Jun 19, 2020
* addresses concerns in #317

* bump all versions (crates only)

* bump version in CHANGES.md

* Changelog:

 - add summary
 - include references only once to make
 changelog more readable
 - add #343
 - rephrase some
 - consistent refs ([#num])

* self reference

* fix link

* readability

* Update CHANGES.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request rpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants