Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for remaining Tendermint RPC endpoints #832

Open
5 of 9 tasks
thanethomson opened this issue Mar 22, 2021 · 8 comments · Fixed by #991
Open
5 of 9 tasks

Add support for remaining Tendermint RPC endpoints #832

thanethomson opened this issue Mar 22, 2021 · 8 comments · Fixed by #991
Labels
enhancement New feature or request rpc

Comments

@thanethomson
Copy link
Contributor

thanethomson commented Mar 22, 2021 •
edited by mzabaluev
Loading

We need to implement client support for the full set of Tendermint RPC endpoints. (Is it necessary to implement the unsafe methods too?)

What's the definition of "done" for this issue?

When we have RPC client support for the following additional endpoints:
@thanethomson thanethomson added enhancement New feature or request rpc labels Mar 22, 2021
@thanethomson thanethomson added this to the Q3 2021 milestone Jul 13, 2021
@thanethomson thanethomson mentioned this issue Sep 13, 2021
Merged
5 tasks
@hu55a1n1 hu55a1n1 mentioned this issue Sep 28, 2021
Merged
5 tasks
@thanethomson
Copy link
Contributor Author

Not sure why GitHub closed this issue.

@thanethomson thanethomson reopened this Sep 28, 2021
@xla
Copy link
Contributor

xla commented Sep 29, 2021 •
edited
Loading

In #991

Partially resolves #832.

The little robots look for certain keywords, resovles is one of them.

@thanethomson
Copy link
Contributor Author

The little robots look for certain keywords

The little robots are pretty dumb, because they missed the most important word in that sentence 😄

@thanethomson thanethomson removed this from the Q3 2021 milestone Jan 25, 2022
@hansl hansl mentioned this issue Feb 10, 2022
Merged
5 tasks
@hansl
Copy link
Contributor

hansl commented Feb 15, 2022

@thanethomson I made a PR that addresses the block_by_hash RPC endpoint: #1089. How can I get started on a review?

@hu55a1n1 hu55a1n1 mentioned this issue Feb 24, 2022
Merged
6 tasks
@hu55a1n1 hu55a1n1 mentioned this issue Mar 7, 2022
Closed
5 tasks
@hansl
Copy link
Contributor

hansl commented Sep 29, 2022

Is there any update on this? After the yanking of TM 0.35 a lot of these endpoints were removed from the latest TM-rs 0.25 release.

fmorency added a commit to fmorency/tendermint-rs that referenced this issue Oct 4, 2022
@fmorency
Fix TM hash encoding
d890cd6 
- Add base64 `tendermint::hash::Hash` encoding/decoding support
- Add base64 `Option<tendermint::hash::Hash>` encoding/decoding support
- Add missing `FromStr` import
- Rename `hash_base64` serializer to `tx_hash_base64`

Relates informalsystems#942
Links informalsystems#832
@fmorency fmorency mentioned this issue Oct 4, 2022
Merged
5 tasks
@hansl
Copy link
Contributor

hansl commented Oct 6, 2022 •
edited
Loading

@thanethomson /block_by_hash can be re-added with #1206 but it needs a reviewer.

thanethomson added a commit that referenced this issue Oct 7, 2022
@fmorency @hansl @thanethomson
Re-add block_by_hash Tendermint endpoint (#1206)
12362fc 
* Add block_by_hash RPC endpoint and tests

Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com>

* rpc-probe part of this

Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com>

* Fix comments

Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com>

* Update .changelog/unreleased/features/832-block-by-hash.md

Co-authored-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com>

* cargo fmt

Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com>

* cargo fmt

* Fix TM hash encoding

- Add base64 `tendermint::hash::Hash` encoding/decoding support
- Add base64 `Option<tendermint::hash::Hash>` encoding/decoding support
- Add missing `FromStr` import
- Rename `hash_base64` serializer to `tx_hash_base64`

Relates #942
Links #832

* Fix outgoing kvstore `block_by_hash` fixture

* Fix clippy

Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com>
Co-authored-by: Hans Larsen <hans@larsen.online>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
@romac
Copy link
Member

romac commented Mar 6, 2023

@mzabaluev Can you please take a look at this and update the issue accordingly to the changes introduced in #1193?

@mzabaluev
Copy link
Contributor

Thanks for the heads-up @romac, I have updated the check boxes accordingly to what is present in #1193.
block_by_hash has already been implemented earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add block_search RPC endpoint informalsystems/tendermint-rs
5 participants
@xla @romac @thanethomson @hansl @mzabaluev