-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block_by_hash RPC endpoint and tests #1089
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1089 +/- ##
========================================
- Coverage 64.6% 64.6% -0.1%
========================================
Files 239 240 +1
Lines 20695 20727 +32
========================================
+ Hits 13387 13405 +18
- Misses 7308 7322 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @hansl! 🎉 Just one minor nit regarding the changelog entry, and I think you need to do a cargo fmt
, then we should be good to merge this.
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Merged your suggestion, and ran cargo fmt. Thanks! |
Links #832.
Implements the block_by_hash RPC which returns an optional block.
.changelog/