Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block_search endpoint isn't tested and doesn't work in CI integration tests #998

Closed
thanethomson opened this issue Sep 29, 2021 · 0 comments · Fixed by #999
Closed

block_search endpoint isn't tested and doesn't work in CI integration tests #998

thanethomson opened this issue Sep 29, 2021 · 0 comments · Fixed by #999
Assignees
@thanethomson
Labels
bug Something isn't working ci Related to continuous integration rpc

Comments

@thanethomson
Copy link
Contributor

After merging #991, I realized that I didn't see that the block_search test isn't actually executed during integration testing, and it actually fails when it's enabled.

Steps to reproduce

Add #[tokio::test] before the block_search method in the kvstore integration test.

What's the definition of "done" for this issue?

When all kvstore integration tests pass.
@thanethomson thanethomson added bug Something isn't working rpc ci Related to continuous integration labels Sep 29, 2021
@thanethomson thanethomson self-assigned this Sep 29, 2021
@thanethomson thanethomson mentioned this issue Sep 29, 2021
Merged
5 tasks
@xla xla closed this as completed in #999 Sep 30, 2021
xla pushed a commit that referenced this issue Sep 30, 2021
@thanethomson
tools: Fix block_search endpoint integration tests (#999)
4f1c553 
Closes #998

* Bump integration test tendermint to v0.34.13
* Fix kvstore integration tests
* Bump tendermint version to v0.34.13 in CI

Signed-off-by: Thane Thomson <connect@thanethomson.com>
soareschen pushed a commit that referenced this issue Oct 6, 2021
@thanethomson @hu55a1n1 @xla
Resolve conflict in #986 (#1004)
540e37f 
* Fix `cargo test` and add check to CI (#990)

* Relocate ABCI test to fix broken doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Use tokio_test for mock client doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add CI test for default features

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add `block_search` RPC endpoint (#991)

* Add block_search RPC endpoint and tests

* Add .changelog entry

* Fix comments

* tools: Fix `block_search` endpoint integration tests (#999)

Closes #998

* Bump integration test tendermint to v0.34.13
* Fix kvstore integration tests
* Bump tendermint version to v0.34.13 in CI

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* ci: Build and check tools (#997)

So far only the kvstore tests ran as part of the Github workfows. This
would leave opportunity for changes to introduce breakage to the builds
of the tools. In this change the same build and clippy stages are
introduced for the tools workspace that currently run for the top-level
one.

Signed-off-by: xla <self@xla.is>

* tools: Add `block_search` method to RPC probe (#1002)

* Add missing block_search endpoint
* Bump tendermint version to v0.34.13

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: xla <a.simmerl@gmail.com>
thanethomson added a commit that referenced this issue Oct 7, 2021
@soareschen @thanethomson
@hu55a1n1 @xla
Move out tendermint::config to tendermint-config crate (#986)
1ab5e86 
* Move out tendermint::config to tendermint_config crate

* Introduce own error type in tendermint-config

* Move tendermint::net to tendermint_config::net

* Fix tendermint-rpc error

* Update Cargo.toml for tendermint-config

* Remove #![allow(dead_code)]

* Apply suggestions from code review

Co-authored-by: Thane Thomson <thane@informal.systems>

* Move tendermint_config::files::test to tendermint_config::test

* Remove config/tests/config.rs

* Minor fixes

* Resolve conflict in #986 (#1004)

* Fix `cargo test` and add check to CI (#990)

* Relocate ABCI test to fix broken doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Use tokio_test for mock client doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add CI test for default features

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add `block_search` RPC endpoint (#991)

* Add block_search RPC endpoint and tests

* Add .changelog entry

* Fix comments

* tools: Fix `block_search` endpoint integration tests (#999)

Closes #998

* Bump integration test tendermint to v0.34.13
* Fix kvstore integration tests
* Bump tendermint version to v0.34.13 in CI

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* ci: Build and check tools (#997)

So far only the kvstore tests ran as part of the Github workfows. This
would leave opportunity for changes to introduce breakage to the builds
of the tools. In this change the same build and clippy stages are
introduced for the tools workspace that currently run for the top-level
one.

Signed-off-by: xla <self@xla.is>

* tools: Add `block_search` method to RPC probe (#1002)

* Add missing block_search endpoint
* Bump tendermint version to v0.34.13

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: xla <a.simmerl@gmail.com>

* Fix abci-test

* Add changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add more changelog entries for other breaking changes

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add tendermint-config to release script

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix merge mistakes

Co-authored-by: Thane Thomson <thane@informal.systems>
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: xla <a.simmerl@gmail.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanethomson thanethomson

Labels
bug Something isn't working ci Related to continuous integration rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: Fix block_search endpoint integration tests informalsystems/tendermint-rs
1 participant
@thanethomson