Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Add block_search method to RPC probe #1002

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Conversation

thanethomson
Copy link
Contributor

Closes #1000

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from xla September 30, 2021 21:44
@thanethomson thanethomson marked this pull request as ready for review September 30, 2021 21:44
@codecov-commenter
Copy link

Codecov Report

Merging #1002 (32dc359) into master (e1c158f) will increase coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 32dc359 differs from pull request most recent head 4604e81. Consider uploading reports for the commit 4604e81 to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1002   +/-   ##
======================================
  Coverage    72.5%   72.5%           
======================================
  Files         204     204           
  Lines       16655   16648    -7     
======================================
+ Hits        12075   12083    +8     
+ Misses       4580    4565   -15     
Impacted Files Coverage Δ
tendermint/src/config.rs 65.0% <0.0%> (+1.5%) ⬆️
tendermint/src/signature.rs 60.7% <0.0%> (+4.0%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c158f...4604e81. Read the comment docs.

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking that on and keep the momentum on the repair of broken windows.

🐉 👦 🐍 🔎

@xla xla merged commit 7239848 into master Oct 1, 2021
@xla xla deleted the thane/1000-block-search branch October 1, 2021 06:12
soareschen pushed a commit that referenced this pull request Oct 6, 2021
* Fix `cargo test` and add check to CI (#990)

* Relocate ABCI test to fix broken doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Use tokio_test for mock client doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add CI test for default features

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add `block_search` RPC endpoint (#991)

* Add block_search RPC endpoint and tests

* Add .changelog entry

* Fix comments

* tools: Fix `block_search` endpoint integration tests (#999)

Closes #998

* Bump integration test tendermint to v0.34.13
* Fix kvstore integration tests
* Bump tendermint version to v0.34.13 in CI

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* ci: Build and check tools (#997)

So far only the kvstore tests ran as part of the Github workfows. This
would leave opportunity for changes to introduce breakage to the builds
of the tools. In this change the same build and clippy stages are
introduced for the tools workspace that currently run for the top-level
one.

Signed-off-by: xla <self@xla.is>

* tools: Add `block_search` method to RPC probe (#1002)

* Add missing block_search endpoint
* Bump tendermint version to v0.34.13

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: xla <a.simmerl@gmail.com>
thanethomson added a commit that referenced this pull request Oct 7, 2021
* Move out tendermint::config to tendermint_config crate

* Introduce own error type in tendermint-config

* Move tendermint::net to tendermint_config::net

* Fix tendermint-rpc error

* Update Cargo.toml for tendermint-config

* Remove #![allow(dead_code)]

* Apply suggestions from code review

Co-authored-by: Thane Thomson <thane@informal.systems>

* Move tendermint_config::files::test to tendermint_config::test

* Remove config/tests/config.rs

* Minor fixes

* Resolve conflict in #986 (#1004)

* Fix `cargo test` and add check to CI (#990)

* Relocate ABCI test to fix broken doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Use tokio_test for mock client doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add CI test for default features

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add `block_search` RPC endpoint (#991)

* Add block_search RPC endpoint and tests

* Add .changelog entry

* Fix comments

* tools: Fix `block_search` endpoint integration tests (#999)

Closes #998

* Bump integration test tendermint to v0.34.13
* Fix kvstore integration tests
* Bump tendermint version to v0.34.13 in CI

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* ci: Build and check tools (#997)

So far only the kvstore tests ran as part of the Github workfows. This
would leave opportunity for changes to introduce breakage to the builds
of the tools. In this change the same build and clippy stages are
introduced for the tools workspace that currently run for the top-level
one.

Signed-off-by: xla <self@xla.is>

* tools: Add `block_search` method to RPC probe (#1002)

* Add missing block_search endpoint
* Bump tendermint version to v0.34.13

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: xla <a.simmerl@gmail.com>

* Fix abci-test

* Add changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add more changelog entries for other breaking changes

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add tendermint-config to release script

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix merge mistakes

Co-authored-by: Thane Thomson <thane@informal.systems>
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: xla <a.simmerl@gmail.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools: Missing implementation for block_search in rpc_probe
3 participants