Make data.Transaction.Rollback a noop if the transaction was already committed #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
requested review from
ssoroka,
BruceMacD,
jmorganca and
pdevine
as code owners
dnephin
force-pushed
the
dnephin/reduce-wrap-route
branch
from
769a089
to
e3239bd
Compare
dnephin
force-pushed
the
dnephin/fix-request-txn
branch
from
789a386
to
c8e5ce9
Compare
dnephin
force-pushed
the
dnephin/reduce-wrap-route
branch
from
e3239bd
to
ef84311
Compare
dnephin
commented
Sep 2, 2022
| return err | ||
| } | ||
|
|
||
| trimWhitespace(req) |
There was a problem hiding this comment.
This moved into readRequest since they are both related to reading the request into the struct.
dnephin
force-pushed
the
dnephin/fix-request-txn
branch
from
b1171c9
to
a2e50cf
Compare
and move trimWhitespace into readRequest since it's related to reading the request.
To reduce the size of wrapRoute
…itted This allows us to remove withDBTxn, and also to simplify the logic in wrapRoute.
dnephin
force-pushed
the
dnephin/reduce-wrap-route
branch
from
ef84311
to
11f0995
Compare
Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Branched from #3103
This PR does some cleanup around transactions. Best viewed by individual commit.
data.Transaction.Rollbacka noop if the transaction was already committed. This makes it possible to defer the rollback, and simplifies the logic where we use transactions.withDBTxnsince it is no longer necessary with the above change.wrapRoute. This function has grown a lot, moving a few small things out of it helps keep it focused and easy to read.