Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make data.Transaction.Rollback a noop if the transaction was already committed #3104

Merged
merged 4 commits into from
Sep 6, 2022
Merged

Make data.Transaction.Rollback a noop if the transaction was already committed #3104

merged 4 commits into from
Sep 6, 2022

Commits on Sep 6, 2022

  1. maintain: rename bind 

    and move trimWhitespace into readRequest since it's related to reading the request.
    @dnephin
    dnephin committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    b9042f6 View commit details
    Browse the repository at this point in the history

  2. maintain: remove all status code logic into the func 

    To reduce the size of wrapRoute
    @dnephin
    dnephin committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    534a01c View commit details
    Browse the repository at this point in the history

  3. improve: make transaction rollback a noop if it has already been comm… 

    …itted

This allows us to remove withDBTxn, and also to simplify the logic in wrapRoute.
    @dnephin
    dnephin committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    11f0995 View commit details
    Browse the repository at this point in the history

  4. improve: fix typo in comment 

    Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com>
    @dnephin @BruceMacD
    dnephin and BruceMacD authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    9a9901d View commit details
    Browse the repository at this point in the history