Fix and test Dockerfile builds #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making fixes in #29 related to lint checks, a local build wasn't done against the Dockerfile, which has a different base image from that used by build_checks for lint verification. The result of that was that building sg-bridge with the Dockerfile failed on gcc compiling due to hardening instructions not being available. This commit does the following: * adds the RPM dependency to the build layer of Dockerfile to install hardening instructions for gcc * changes the default -march CFLAG to be x86-64 instead of x86-64-v2 which fails in ubi8 * updates the GHA to add a build check against the Dockerfile and not just run build_checks.sh for future validation Found by csibbitt and noted in chat. Resolves #30 Signed-off-by: Leif Madsen <lmadsen@redhat.com>
csibbitt
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
I successfully tested this in an STO local CI build, which is where I found it failing:
$ ansible-playbook --extra-vars working_branch=lmadsen/fix-building --extra-vars __local_build_enabled=true --extra-vars __service_telemetry_snmptraps_enabled=true --extra-vars __service_telemetry_observability_strategy=use_redhat --extra-vars __deploy_stf=false ./build/run-ci.yaml
[...]
"outputDockerImageReference": "image-registry.openshift-image-registry.svc:5000/service-telemetry/sg-bridge:latest",
"phase": "Complete",
[...]
PLAY RECAP ******************************************************************************************************************************************************************************
localhost : ok=108 changed=30 unreachable=0 failed=0 skipped=26 rescued=3 ignored=0
$ oc get build sg-bridge-2
NAME TYPE FROM STATUS STARTED DURATION
sg-bridge-2 Docker Binary@97205fe Complete 4 minutes ago 50s
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making fixes in #29 related to lint checks, a local build wasn't
done against the Dockerfile, which has a different base image from that
used by build_checks for lint verification. The result of that was that
building sg-bridge with the Dockerfile failed on gcc compiling due to
hardening instructions not being available.
This commit does the following:
hardening instructions for gcc
which fails in ubi8
just run build_checks.sh for future validation
Found by csibbitt and noted in chat.
Resolves #30
Signed-off-by: Leif Madsen lmadsen@redhat.com