Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import/stf 1 5 3 #32

Closed
wants to merge 3 commits into from
Closed

import/stf 1 5 3 #32

wants to merge 3 commits into from

Conversation

leifmadsen
Copy link
Member

vyzigold and others added 3 commits August 2, 2023 11:59
@vyzigold
Fix buffer overflow (#27)
bc9d982 
* Fix buffer overflow.

Before this, the amqp messages would get copied to
ring buffer without checking, if there is enough space
in the buffer. That would lead to buffer overflows for
long messages. Now the sizes are checked and if the
message is longer than the buffer, it's first read
from the bus and then it's discarded.

* Committing clang-format changes

---------

Co-authored-by: InfraWatch CI <robot@infra.watch>
@leifmadsen
[testing] Update linter to more recent component versions (#29)
ede398f 
* Update base image for GHA test and linter versions

* annocheck should run in verbose mode

* Try using -flto flag to build

* Try adding -fplugin=annobin to better cover code

* Add gcc-plugin-annobin package to deployment

* Generate missing build notes so annocheck passes

* Final set of changes based on feedback

After further investigation it was found that the Makefile was missing
calls to CFLAGS which was causing issues with notes generation. That has
now been fixed.

Also the CFLAGS and LDFLAGS have been updated to match the latest best
values provided to us by release-delivery.

Additionally the CFLAGS and LDFLAGS configuration have been moved out of
the external build_checks.sh script into the Makefile directly so that
the build_checks script can just run make directly, as well as setting
proper defaults for how we expect sg-bridge to be built.

Signed-off-by: Leif Madsen <lmadsen@redhat.com>

---------

Signed-off-by: Leif Madsen <lmadsen@redhat.com>
@leifmadsen
Fix and test Dockerfile builds (#31)
be893b7 
When making fixes in #29 related to lint checks, a local build wasn't
done against the Dockerfile, which has a different base image from that
used by build_checks for lint verification. The result of that was that
building sg-bridge with the Dockerfile failed on gcc compiling due to
hardening instructions not being available.

This commit does the following:

* adds the RPM dependency to the build layer of Dockerfile to install
  hardening instructions for gcc
* changes the default -march CFLAG to be x86-64 instead of x86-64-v2
  which fails in ubi8
* updates the GHA to add a build check against the Dockerfile and not
  just run build_checks.sh for future validation

Found by csibbitt and noted in chat.

Resolves #30

Signed-off-by: Leif Madsen <lmadsen@redhat.com>
@leifmadsen leifmadsen closed this Oct 26, 2023
@leifmadsen leifmadsen deleted the import/stf-1-5-3 branch October 26, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leifmadsen @vyzigold