refactor: Refactor common functions and fix typos #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracted common logic into helper functions to reduce code duplication. - Improved readability by consolidating attribute extraction logic into `getAttribute()` and `parsePacketAttributes()`. - No functional changes, purely a code quality improvement.
- Replaced multiple if-else statements in blockIdFlagConvert with a mapping object to simplify logic. - Improved readability and maintainability by making flag conversion more concise. - This change has no impact on functionality but makes the code easier to extend in the future.
Corrected several typos and grammatical errors for improved readability.
|
close due to fixed and struct changed in #14 Thank you for contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos in README.md
Refactor eventParser.ts
Simplify blockIdFlag conversion in signedHeader.ts
if-elsestatements for cleaner and more efficient code.