Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DB to support ordered channel, ICA and packet fee #14

Merged
merged 34 commits into from
Dec 6, 2024
Merged

Use DB to support ordered channel, ICA and packet fee #14

merged 34 commits into from
Dec 6, 2024

Conversation

ALPAC-4
Copy link
Collaborator

@ALPAC-4 ALPAC-4 commented Nov 1, 2024

Use sqlite to store indexed events to support:

  • Ordered Channel
  • Channel Creation (to support ICA)
  • Packet Fee

@beer-1 beer-1 self-requested a review November 1, 2024 03:14
beer-1
beer-1 reviewed Nov 4, 2024
View reviewed changes
src/db/controller/channel.ts Outdated Show resolved Hide resolved
beer-1
beer-1 reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall works are LGTM, just left minor comments and will create separate PR for typo and some small changes.

src/db/controller/packet.ts Show resolved Hide resolved
src/db/controller/packet.ts Outdated Show resolved Hide resolved
src/db/constants.ts Outdated Show resolved Hide resolved
src/db/controller/channel.ts Show resolved Hide resolved
src/lib/eventParser.ts Outdated Show resolved Hide resolved
src/db/controller/syncInfo.ts Show resolved Hide resolved
src/workers/wallet.ts Show resolved Hide resolved
src/workers/wallet.ts Outdated Show resolved Hide resolved
src/workers/wallet.ts Outdated Show resolved Hide resolved
src/workers/wallet.ts Outdated Show resolved Hide resolved
beer-1
beer-1 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ALPAC-4 ALPAC-4 merged commit 8d9143c into main Dec 6, 2024
3 checks passed
@ALPAC-4 ALPAC-4 deleted the feat/store-events branch December 6, 2024 06:15
This was referenced Dec 6, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beer-1 beer-1 beer-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ALPAC-4 @beer-1