-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cardano-services-client): comply HttpProvider with 'normal' Object behavior #1521
Conversation
…t behavior HttpProvider is implemented as a Proxy object, which is currently not compatible with SDK's web-extension messaging utilities that are checking exposed/underlying object properties with 'in' operator This commit has 2 fixes: - do not throw an error when trying to access an undefined property of an object - return 'true' with with 'in' operator for defined properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Happy to approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood correctly... otherwise please ignore my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Context
HttpProvider is implemented as a Proxy object, which is currently not compatible with SDK's web-extension messaging utilities that are checking exposed/underlying object properties with 'in' operator
LW-11796
Proposed Solution
This commit has 2 fixes:
Important Changes Introduced