[Fix] Simplify release mechanism by removing scapegoat selection #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienRichez
approved these changes
Jul 12, 2021
dzajkowski
force-pushed
the
fix/revert-scapegoat-plugin-version
branch
from
4990ab1 to
2379374
Compare
dzajkowski
changed the title
aakoshh
reviewed
Jul 12, 2021
| @@ -48,14 +48,13 @@ export CI_SONATYPE_RELEASE=$"; bytes/sonatypeBundleRelease; rlp/sonatypeBundleRe | |||
| # so as a workaround the combos are called here explicitly. | |||
There was a problem hiding this comment.
Did you leave that comment for historic reason for why release was introduced in the first place?
By the way it's possible now that ci-release could handle everything.
As per my other comment here, inserting a + before each module would do the cross release, and then there wouldn't be a need to repeat the exact scala versions here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bumping sbt a scapegoat selection mechanism was removed. It's still required.