Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Simplify release mechanism by removing scapegoat selection #1051

Merged
merged 1 commit into from
Jul 12, 2021
Merged

[Fix] Simplify release mechanism by removing scapegoat selection #1051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .buildkite/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,13 @@ export CI_SONATYPE_RELEASE=$"; bytes/sonatypeBundleRelease; rlp/sonatypeBundleRe
# so as a workaround the combos are called here explicitly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you leave that comment for historic reason for why release was introduced in the first place?

By the way it's possible now that ci-release could handle everything.

As per my other comment here, inserting a + before each module would do the cross release, and then there wouldn't be a need to repeat the exact scala versions here.

function release {
SCALA_VERSION=$1
export SCAPEGOAT_VERSION=$2

sbt "++ $SCALA_VERSION ; ci-release"
}

function releaseAll {
release 2.12.10 1.4.5
release 2.13.4 1.4.7
release 2.12.13
release 2.13.6
}

if [[ "$BUILDKITE_BRANCH" == "develop" ]]; then
Expand Down