Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single signature store in Mithril Aggregator #295

Merged
merged 8 commits into from
Jun 24, 2022

Conversation

jpraynaud
Copy link
Member

This PR includes the implementation of a single signature store in the Mithril Aggregator:

  • The single signatures are now stored in a dedicated store
  • The store is used in the multi signer
  • Also, the verification of the single signatures has been accelerated thanks to the caching of the clerk used for that purpose.

Relates to #282

@github-actions
Copy link

Unit Test Results

217 tests  +4   217 ✔️ +4   9m 47s ⏱️ +58s
  17 suites ±0       0 💤 ±0 
    6 files   ±0       0 ±0 

Results for commit 851c278. ± Comparison against base commit 1a7d271.

@jpraynaud jpraynaud marked this pull request as ready for review June 24, 2022 07:25
@jpraynaud jpraynaud requested review from ghubertpalo and Alenar June 24, 2022 07:25
@jpraynaud jpraynaud merged commit 586a9da into main Jun 24, 2022
@jpraynaud jpraynaud deleted the jpraynaud/282-single-signature-store branch June 24, 2022 08:54
@Alenar Alenar mentioned this pull request Jul 12, 2022
Alenar added a commit that referenced this pull request Jul 12, 2022
Lessen test lab flakyness

- Update devnet parameters for faster epoch & immutable files creation
- Adjust aggregator & signers run interval to be faster.
- Add a new step in the E2E tests to wait until the current epoch is at least equal to the epoch offset (below it the signers won't be able to sign).
- Set the number of signers & cardano pool node to 2 since the aggregator register signatures faster since #295.
- Quick fix
   - aggregator: multi-signer won't crash if the current epoch is lower than the epoch offset
   - signer: init protocol initializer earlier to have them even if following code have an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants