Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lessen test lab flakyness #350

Merged
merged 10 commits into from
Jul 12, 2022
Merged

Lessen test lab flakyness #350

merged 10 commits into from
Jul 12, 2022

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Jul 11, 2022

  • Update devnet parameters for faster epoch & immutable files creation
  • Set the epoch offset (for signer & stake distribution) from 0 to 1 Postponed until we find why signers must wait until epoch 3 to sign
  • Adjust aggregator & signers run interval to be faster.
  • Add a new step in the E2E tests to wait until the current epoch is at least equal to the epoch offset (below it the signers won't be able to sign).
  • Set the number of signers & cardano pool node to 2 since the aggregator register signatures faster since Use single signature store in Mithril Aggregator #295.
  • Quick fix
    • aggregator: multi-signer won't crash if the current epoch is lower than the epoch offset
    • signer: init protocol initializer earlier to have them even if following code have an error.

@Alenar Alenar requested a review from jpraynaud July 11, 2022 16:49
@github-actions
Copy link

github-actions bot commented Jul 11, 2022

Unit Test Results

229 tests  ±0   229 ✔️ ±0   6m 14s ⏱️ -50s
  18 suites ±0       0 💤 ±0 
    6 files   ±0       0 ±0 

Results for commit e1e5125. ± Comparison against base commit 8dab45f.

♻️ This comment has been updated with latest results.

@Alenar Alenar force-pushed the djo/fix_test_lab_flakkyness branch 2 times, most recently from 7ca4600 to 1b4ba34 Compare July 12, 2022 08:04
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@Alenar Alenar force-pushed the djo/fix_test_lab_flakkyness branch from b017d66 to 73f06a9 Compare July 12, 2022 08:56
@Alenar Alenar force-pushed the djo/fix_test_lab_flakkyness branch from ba8d6b5 to e1e5125 Compare July 12, 2022 09:11
@Alenar Alenar merged commit 24aafef into main Jul 12, 2022
@Alenar Alenar deleted the djo/fix_test_lab_flakkyness branch July 12, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants