Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix building docker image locally #416

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix building docker image locally #416

merged 2 commits into from
Jan 23, 2025

Conversation

LGLO
Copy link
Contributor

@LGLO LGLO commented Jan 22, 2025 •
edited
Loading

Description

I have to admit it was broken for a long time. Since moving docker into dev directory.
I don't remove it at all, because it is the way to build it locally for people that have problems with running earthly.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@LGLO LGLO enabled auto-merge (squash) January 23, 2025 10:00
@LGLO LGLO merged commit 740e69e into master Jan 23, 2025
11 checks passed
@LGLO LGLO deleted the fix-dev-docker branch January 23, 2025 10:13
skylar-simoncelli pushed a commit that referenced this pull request Jan 27, 2025
@LGLO @sidechains-substrate-node
fix building docker image locally (#416)
d7249ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmbientTea AmbientTea AmbientTea approved these changes

@alexromanov alexromanov Awaiting requested review from alexromanov

@skylar-simoncelli skylar-simoncelli Awaiting requested review from skylar-simoncelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LGLO @AmbientTea