Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix building docker image locally #416

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix building docker image locally #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d611204
fix building docker image locally
LGLO Jan 22, 2025
bd8736b
Merge branch 'master' into fix-dev-docker
LGLO Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM sidechains-substrate-node-builder:latest as builder
FROM partner-chains-node-builder:latest AS builder

FROM docker.io/library/ubuntu:20.04
COPY --from=builder /partner-chains-node/docker-build/target/release/partner-chains-node /usr/local/bin
Expand All @@ -7,7 +7,7 @@ RUN useradd -m -u 1000 -U -s /bin/sh -d /substrate substrate && \
mkdir -p /data /substrate/.local/share/partner-chains-node && \
chown -R substrate:substrate /data && \
ln -s /data /substrate/.local/share/partner-chains-node && \
# Sanity checks
# Sanity checks
ldd /usr/local/bin/partner-chains-node && \
/usr/local/bin/partner-chains-node --version

Expand Down
5 changes: 3 additions & 2 deletions dev/docker/build-images-local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/usr/bin/env sh
docker build --pull -f docker/builder.Dockerfile -t "partner-chains-node-builder:latest" --ssh default . && \
docker build -f docker/Dockerfile -t partner-chains-node:latest docker
# This script has to be executed from the root of the repository to enable proper context for the Docker build. `./dev/docker/build-images-local.sh`
docker build --pull -f dev/docker/builder.Dockerfile -t "partner-chains-node-builder:latest" --ssh default . && \
docker build -f dev/docker/Dockerfile -t partner-chains-node:latest dev/docker
4 changes: 2 additions & 2 deletions dev/docker/builder.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
FROM docker.io/paritytech/ci-unified:bullseye-1.81.0-2024-09-11-v202409111034 as builder
FROM docker.io/paritytech/ci-unified:bullseye-1.81.0-2024-09-11-v202409111034 AS builder

WORKDIR /partner-chains-node
COPY . /partner-chains-node

RUN mkdir -p docker-build/cargo-home || echo "cargo-home already exists" && \
export CARGO_HOME="$(pwd)/docker-build/cargo-home"
export CARGO_HOME="$(pwd)/docker-build/cargo-home"
RUN --mount=type=ssh cargo build --release --target-dir=docker-build/target
Loading