-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial for closure_phase_bias.py #40
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB yunjunz commented on 2022-05-26T19:38:34Z You may want to add the full reference info here, something like:
+ Y. Zheng, H. Fattahi, P. Agram, M. Simons and P. Rosen, "On Closure Phase and Systematic Bias in Multi-looked SAR Interferometry," in IEEE Transactions on Geoscience and Remote Sensing, 60, doi: [10.1109/TGRS.2022.3167648](https://ieeexplore.ieee.org/document/9758802). |
View / edit / reply to this conversation on ReviewNB yunjunz commented on 2022-05-26T19:38:35Z Use list syntax in Markdown for the 3 options please. sisi-ali commented on 2022-07-31T05:30:03Z Hi dear I'm using ISCE software and I can't download DEM. How can I download DEM ? Could you please guide me? I have this Error() s a problem in retrieving the file - WARNING - There was http://e4ftl01.cr.usgs.gov/MEASURES/SRTMGL1. http://e4ftl01.cr.usgs.gov/MEASURES/SRTMGL1. 003/2000.02.11/N30E049.SRTMGL1.hgt.zip. Exception Could not create a stitched DEM. Some tiles are missing |
Very nice notebook demonstration @yjzhenglamarmota! I only have a few minor comments above. Could you also add a link to this notebook to the README.md file under |
I have committed suggested changes. |
@sisi-ali The closure phase bias PR (#765) is not merged yet, which means it's not ready to be used. Please try to not post the same comment in multiple places. Comments here are relevant and welcomed. |
I have updated the notebook to keep up with the new and hopefully finalized version in MintPy. |
Could you add an explanation for the View entire conversation on ReviewNB |
View / edit / reply to this conversation on ReviewNB yunjunz commented on 2022-07-27T01:01:40Z Add |
View / edit / reply to this conversation on ReviewNB yunjunz commented on 2022-07-27T01:01:41Z The title needs update, to be consistent with the script options. Same for the rest of the titles. |
View / edit / reply to this conversation on ReviewNB yunjunz commented on 2022-07-27T01:01:42Z This generated dataset is really a valid-data mask, I would not call it water mask to avoid confusion. Thus, I would suggest removing this cell.
You could generate water mask following https://nbviewer.org/github/insarlab/MintPy-tutorial/blob/main/applications/water_mask.ipynb, and update your example dataset on zenodo. |
View / edit / reply to this conversation on ReviewNB yunjunz commented on 2022-07-27T01:01:42Z I believe the file name is |
Hi dear
I'm using ISCE software and I can't download DEM.
How can I download DEM ?
Could you please guide me?
I have this Error()
s a problem in retrieving the file - WARNING - There was
http://e4ftl01.cr.usgs.gov/MEASURES/SRTMGL1.
http://e4ftl01.cr.usgs.gov/MEASURES/SRTMGL1.
003/2000.02.11/N30E049.SRTMGL1.hgt.zip. Exception Could not create a
stitched DEM. Some tiles are missing
review-notebook-app[bot] ***@***.***> در تاریخ
چهارشنبه ۲۷ ژوئیه ۲۰۲۲ ساعت ۵:۳۱ نوشت:
… View / edit / reply to this conversation
<https://app.reviewnb.com/insarlab/MintPy-tutorial/pull/40/discussion/>
on ReviewNB
*yunjunz commented on 2022-07-27T01:01:42Z*
----------------------------------------------------------------
I believe the file name is wratio.h5 without caplitalized.
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZ3AKUVFN74HRZUXI5EBBMTVWCDADANCNFSM5WC65LVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi dear I'm using ISCE software and I can't download DEM. How can I download DEM ? Could you please guide me? I have this Error() s a problem in retrieving the file - WARNING - There was http://e4ftl01.cr.usgs.gov/MEASURES/SRTMGL1. http://e4ftl01.cr.usgs.gov/MEASURES/SRTMGL1. 003/2000.02.11/N30E049.SRTMGL1.hgt.zip. Exception Could not create a stitched DEM. Some tiles are missing View entire conversation on ReviewNB |
@sisi-ali Check here: isce-framework/isce2#458 (comment) |
@yunjunz Updated notebook |
Tutorial for closure_phase_bias.py
Also add local pics in Docs; added data info in tutorial.
Added instruction about option -3 to have consistent bandwidth in the ifgramStack.h5 and the input parameters.
Added parallization Added requirement for modify_network before option 3
To be compatible with the updated code.
also perform minor modifications/
updated the notebook to keep up with the finalized code in mintpy
MInor changes and changed the notebook name
hi dear,
I can not download DEM yet.
my study area is 30 33 47 50
Yujie Zheng ***@***.***> در تاریخ سهشنبه ۲ اوت ۲۰۲۲
ساعت ۲۳:۳۲ نوشت:
… @yunjunz <https://github.com/yunjunz> Updated notebook
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZ3AKUX3PZL65HLTOJDWAZDVXFWGFANCNFSM5WC65LVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
+ light markdown refactoring to highlight files/dirs and equations + merge the two figures into one and use jpg instead of png to reduce file size to 1 MB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me. Thank you @yjzhenglamarmota for this super useful notebook!!
hi
I work with MintPy software and I want to get phase_clouser_bias, but it is
not possible, I use this code (
https://github.com/insarlab/MintPy/blob/main/mintpy/closure_phase_bias.py)
Thank you for guiding me
sedigheh alihasani ***@***.***> در تاریخ
پنجشنبه ۴ اوت ۲۰۲۲ ساعت ۱۰:۳۳ نوشت:
… hi dear,
I can not download DEM yet.
my study area is 30 33 47 50
Yujie Zheng ***@***.***> در تاریخ سهشنبه ۲ اوت ۲۰۲۲
ساعت ۲۳:۳۲ نوشت:
> @yunjunz <https://github.com/yunjunz> Updated notebook
>
> —
> Reply to this email directly, view it on GitHub
> <#40 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AZ3AKUX3PZL65HLTOJDWAZDVXFWGFANCNFSM5WC65LVQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
@sisi-ali please keep the same posting to one issue/discussion only. |
Tutorial for closure_phase_bias.py (insarlab/MintPy#765).
Data can be downloaded from https://doi.org/10.5281/zenodo.6558341