Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial for closure_phase_bias.py #40

Merged
merged 10 commits into from
Aug 12, 2022
Merged

Conversation

yjzhenglamarmota
Copy link
Contributor

@yjzhenglamarmota yjzhenglamarmota commented May 16, 2022

Tutorial for closure_phase_bias.py (insarlab/MintPy#765).

Data can be downloaded from https://doi.org/10.5281/zenodo.6558341

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@yunjunz yunjunz requested review from yunjunz and hfattahi May 16, 2022 22:42
@review-notebook-app
Copy link

review-notebook-app bot commented May 26, 2022

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-26T19:38:34Z
----------------------------------------------------------------

You may want to add the full reference info here, something like:

+ Y. Zheng, H. Fattahi, P. Agram, M. Simons and P. Rosen, "On Closure Phase and Systematic Bias in Multi-looked SAR Interferometry," in IEEE Transactions on Geoscience and Remote Sensing, 60, doi: [10.1109/TGRS.2022.3167648](https://ieeexplore.ieee.org/document/9758802).

@review-notebook-app
Copy link

review-notebook-app bot commented May 26, 2022

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-26T19:38:35Z
----------------------------------------------------------------

Use list syntax in Markdown for the 3 options please.


sisi-ali commented on 2022-07-31T05:30:03Z
----------------------------------------------------------------

Hi dear 

I'm using ISCE software and I can't download DEM. 

How can I download DEM ? 

Could you please guide me?

I have this Error()

s a problem in retrieving the file - WARNING - There was  http://e4ftl01.cr.usgs.gov/MEASURES/SRTMGL1.

http://e4ftl01.cr.usgs.gov/MEASURES/SRTMGL1. 003/2000.02.11/N30E049.SRTMGL1.hgt.zip. Exception Could not create a stitched DEM. Some tiles are missing

@yunjunz
Copy link
Member

yunjunz commented May 26, 2022

Very nice notebook demonstration @yjzhenglamarmota! I only have a few minor comments above.

Could you also add a link to this notebook to the README.md file under 4. Custom applications for easy navigation?

@yjzhenglamarmota
Copy link
Contributor Author

Very nice notebook demonstration @yjzhenglamarmota! I only have a few minor comments above.

Could you also add a link to this notebook to the README.md file under 4. Custom applications for easy navigation?

I have committed suggested changes.

@yunjunz
Copy link
Member

yunjunz commented Jun 30, 2022

hi dear yjzhenglamarmota , can you guide me please, on how can I install package closure_phase_bias.py?

@sisi-ali The closure phase bias PR (#765) is not merged yet, which means it's not ready to be used.

Please try to not post the same comment in multiple places. Comments here are relevant and welcomed.

@yjzhenglamarmota
Copy link
Contributor Author

I have updated the notebook to keep up with the new and hopefully finalized version in MintPy.

README.md Show resolved Hide resolved
Copy link
Member

yunjunz commented Jul 27, 2022

Could you add an explanation for the quick_estimate like, based on..., or assuming ....?


View entire conversation on ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Jul 27, 2022

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-07-27T01:01:40Z
----------------------------------------------------------------

Add Author info here, similar to https://github.com/insarlab/MintPy-tutorial/blob/main/smallbaselineApp_aria.ipynb.


@review-notebook-app
Copy link

review-notebook-app bot commented Jul 27, 2022

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-07-27T01:01:41Z
----------------------------------------------------------------

The title needs update, to be consistent with the script options. Same for the rest of the titles.


@review-notebook-app
Copy link

review-notebook-app bot commented Jul 27, 2022

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-07-27T01:01:42Z
----------------------------------------------------------------

This generated dataset is really a valid-data mask, I would not call it water mask to avoid confusion. Thus, I would suggest removing this cell.

You could generate water mask following https://nbviewer.org/github/insarlab/MintPy-tutorial/blob/main/applications/water_mask.ipynb, and update your example dataset on zenodo.


@review-notebook-app
Copy link

review-notebook-app bot commented Jul 27, 2022

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-07-27T01:01:42Z
----------------------------------------------------------------

I believe the file name is wratio.h5 without caplitalized.


@sisi-ali
Copy link

sisi-ali commented Jul 30, 2022 via email

Copy link

Hi dear 

I'm using ISCE software and I can't download DEM. 

How can I download DEM ? 

Could you please guide me?

I have this Error()

s a problem in retrieving the file - WARNING - There was  http://e4ftl01.cr.usgs.gov/MEASURES/SRTMGL1.

http://e4ftl01.cr.usgs.gov/MEASURES/SRTMGL1. 003/2000.02.11/N30E049.SRTMGL1.hgt.zip. Exception Could not create a stitched DEM. Some tiles are missing


View entire conversation on ReviewNB

@yunjunz
Copy link
Member

yunjunz commented Jul 31, 2022

@sisi-ali Check here: isce-framework/isce2#458 (comment)

@yjzhenglamarmota
Copy link
Contributor Author

@yunjunz Updated notebook

Tutorial for closure_phase_bias.py
Also add local pics in Docs; added data info in tutorial.
Added instruction about option -3 to have consistent bandwidth in the ifgramStack.h5 and the input parameters.
Added parallization
Added requirement for modify_network before option 3
To be compatible with the updated code.
also perform minor modifications/
updated the notebook to keep up with the finalized code in mintpy
MInor changes and changed the notebook name
@sisi-ali
Copy link

sisi-ali commented Aug 4, 2022 via email

+ light markdown refactoring to highlight files/dirs and equations

+ merge the two figures into one and use jpg instead of png to reduce file size to 1 MB.
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. Thank you @yjzhenglamarmota for this super useful notebook!!

@yunjunz yunjunz merged commit 526ac74 into insarlab:main Aug 12, 2022
@sisi-ali
Copy link

sisi-ali commented Aug 23, 2022 via email

@yunjunz
Copy link
Member

yunjunz commented Aug 23, 2022

@sisi-ali please keep the same posting to one issue/discussion only.

@yunjunz yunjunz mentioned this pull request Nov 23, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants