Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: drop defusedxml #915

Merged
merged 4 commits into from
Nov 23, 2022
Merged

deps: drop defusedxml #915

merged 4 commits into from
Nov 23, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Nov 23, 2022

Description of proposed changes

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

revert back the ElementTree usage from `defusedxml` to the native `xml.etree` module, to drop this extra dependency, because there are only two use cases in the code: parse known XML files from ISCE and SNAP. insarlab#340
@yunjunz yunjunz merged commit 143fef5 into insarlab:main Nov 23, 2022
@yunjunz yunjunz deleted the xml branch November 23, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant